Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjustments to help bring package back to CRAN #118

Merged
merged 15 commits into from
May 7, 2024
Merged

Conversation

olivroy
Copy link
Contributor

@olivroy olivroy commented Feb 21, 2024

Fixes #117

tidyselect deprecation warnings.
I accepted snapshots with ggplot2 3.5.0
Updated gh actions with usethis::use_github_action().

There is one failure I can't seem to reproduce. You will see in the logs, but summary_slope seems to have lost one row, and I don't know if it is intentional o not.

I also removed unused packages from Suggests. (only leaving those used for examples, vignettes + tests) (readr is only used for creating a data in data-raw. markdown in not used, covr is used for the coverage (gh action installs it the same way the pkgdown gh action installs pkgdown)

Also removed what I assumed to be old vdiffr output.

Note that I see this failure locally, but I don't know what is causing it, nor if it is intended.

I don't understand the r-devel one, nor do I see it on Windows 4.3.2

@njtierney
Copy link
Owner

Wow, thank you @olivroy !

@olivroy
Copy link
Contributor Author

olivroy commented Feb 21, 2024

@njtierney this should fix a first round of issues. (the cached Matrix version = 1.6-2) was the culprit for vignette build failures!

@njtierney
Copy link
Owner

Thanks so much again! I'm just going to run some checks locally, but I should be able to push this along very soon!

@olivroy
Copy link
Contributor Author

olivroy commented May 6, 2024

Hi Nick, just wanted to remind you of this!

I have not had the chance to upgrade to R 4.4 yet, but if you have, maybe the failure is easier to reproduce locally?

* This results in (effectively) fun(x, arg1 = TRUE, arg1 = TRUE), which will error
@njtierney
Copy link
Owner

Thanks @olivroy ! This works locally for me, I'm not trusting GH actions right now, I've heard that there are a bunch of issues at the moment with GH actions.

Thanks again for all your help with this, and for the prompt! I had a small bug that I encountered, which should be solved now.

Copy link
Owner

@njtierney njtierney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for your work on this @olivroy !

@njtierney njtierney merged commit cdfbe7a into njtierney:main May 7, 2024
2 of 7 checks passed
@njtierney
Copy link
Owner

Re

There is one failure I can't seem to reproduce. You will see in the logs, but summary_slope seems to have lost one row, and I don't know if it is intentional o not.

I believe this is just due to something random, this all looked fine to me otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix brolgar package Alias
2 participants