Fixes after options, terra, and tar_terra_sprc() updates
#60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- handle case when getOption() returns vector length >1 - fix get_gdal_available_driver_list() for terra::gdal(drivers=TRUE) - Fix specification of raster creation options in tar_terra_sprc() test
|
This looks great to me and passes checks - thanks for submitting, @brownag ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are some things I noticed while bringing the tar-stars (#33) branch up to date. Doing a separate PR as they are not related to the {stars} changes
In this PR:
geotargets_option_get(): Handle case whengetOption()returns vector length >1get_gdal_available_driver_list(): Fix forterra::gdal(drivers=TRUE)table format. This has changed in the development version of terra (currently 1.7-75 vs. CRAN 1.7-71). For now handle older package versions differently by checking withpackageVersion()before subsetting driver list. {terra} now reports drivers similarly to how {sf} does RE: GDAL drivers with raster and vector capabilities not properly reported ingdal(drivers=TRUE)rspatial/terra#1465tar_terra_sprc(): Fix specification of multiple raster creation options in test and add snapshot