Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consistently use the same summary functions #41

Open
njtierney opened this issue Feb 8, 2017 · 0 comments
Open

consistently use the same summary functions #41

njtierney opened this issue Feb 8, 2017 · 0 comments

Comments

@njtierney
Copy link
Owner

It would be great if all of the summary type functions didn't repeat hand-written code or repeat other chunks of code.

So, ideally I should be using the recently added summary_user_cov and n_relocated and augment_ functions inside the maxcovr functions, either as an extraction type method, or something else.

Also keep in mind that there should be a broom::tidy-like function, as well as something like a rmse or other summary that works with map2.

So I should be able to do something like map2(lm_train, test, rmse).

So instead I guess that would be: map2(mc_model_train, test, summary_user_cov).

@njtierney njtierney added this to the 0.2.0 milestone Jul 5, 2018
@njtierney njtierney modified the milestones: 0.4.0, 0.3.0 Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant