Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/list column #291

Merged
merged 4 commits into from
Jan 31, 2023
Merged

Conversation

cregouby
Copy link

@cregouby cregouby commented Sep 10, 2021

Description

Add support of list column missing value in shade

Related Issue

fix #277
visdat::vis_miss() dependancy will be fixed by ropensci/visdat#138

Example

> star_1 <- starwars %>% select(vehicles, starships) %>%  sample_n(6)
> nabular(star_1)
# A tibble: 6 × 4
  vehicles  starships vehicles_NA starships_NA
  <list>    <list>    <fct>       <fct>       
1 <chr [0]> <chr [0]> NA          NA          
2 <chr [0]> <chr [0]> NA          NA          
3 <chr [0]> <chr [0]> NA          NA          
4 <chr [0]> <chr [2]> NA          !NA         
5 <chr [0]> <chr [0]> NA          NA          
6 <chr [0]> <chr [0]> NA          NA          

Tests

two tests are added in test-shade.R

✓ | 12 | test-shade.R

NEWS + DESCRIPTION

## New features

- naniar now supports list-columns

@njtierney njtierney merged commit 1eb0d73 into njtierney:master Jan 31, 2023
@njtierney
Copy link
Owner

Thank you @cregouby ! 🚀

@cregouby cregouby deleted the feature/list_column branch February 4, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request : add support to list-column
3 participants