Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support from semanticscholar #16

Merged
merged 3 commits into from
May 21, 2024
Merged

support from semanticscholar #16

merged 3 commits into from
May 21, 2024

Conversation

njzjz
Copy link
Owner

@njzjz njzjz commented May 20, 2024

No description provided.

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@pep8speaks
Copy link

pep8speaks commented May 20, 2024

Hello @njzjz! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 350:80: E501 line too long (105 > 79 characters)
Line 357:80: E501 line too long (100 > 79 characters)
Line 358:80: E501 line too long (100 > 79 characters)
Line 366:80: E501 line too long (85 > 79 characters)
Line 367:80: E501 line too long (93 > 79 characters)
Line 375:80: E501 line too long (93 > 79 characters)
Line 376:80: E501 line too long (93 > 79 characters)
Line 377:80: E501 line too long (92 > 79 characters)

Line 17:80: E501 line too long (86 > 79 characters)

Comment last updated at 2024-05-21 00:12:47 UTC

Copy link

codecov bot commented May 20, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 90.86%. Comparing base (2cf4cd2) to head (e7e141e).

Files Patch % Lines
wenxian/feeder/semanticscholar.py 91.30% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #16      +/-   ##
==========================================
+ Coverage   90.75%   90.86%   +0.10%     
==========================================
  Files          10       11       +1     
  Lines         346      372      +26     
==========================================
+ Hits          314      338      +24     
- Misses         32       34       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@njzjz njzjz merged commit 2f37a75 into master May 21, 2024
6 checks passed
@njzjz njzjz deleted the semanticscholar branch May 21, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants