Fix groups never suppressing as a group #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tweaks the early suppression check-- adding height to ensure more reliable suppressing events. Fixes missing enableAttack use
jokoho48
approved these changes
Dec 15, 2021
nk3nny
added a commit
that referenced
this pull request
Dec 16, 2021
- Adds sorting enemies based on distance - Fixes groups failing to deploy static weapons (and sometimes UGL flares) - Changed - reverts Suppression chance to accomodate #304 - Removed vanilla attack feature from groups* *This is a big one which we've talked about internally before. What this does is remove the lock-in units sometimes suffer due to the vanilla ATTACK pattern/fsm. I propose to check this on the development version. Our own _group_ level attack patterns are better than the individual vanilla ones. But the AI is a complicated beast. Additional testing should be done.
This was referenced Dec 16, 2021
Merged
diwako
reviewed
Dec 16, 2021
| // set group task | ||
| private _group = group _unit; | ||
| _group enableAttack false; |
There was a problem hiding this comment.
when will this be set to true again?
There was a problem hiding this comment.
L39 of same file. When the reset is configured. Actually toggling attack mode was missing.
nk3nny
added a commit
that referenced
this pull request
Feb 2, 2022
* Improved tactics assess - Adds sorting enemies based on distance - Fixes groups failing to deploy static weapons (and sometimes UGL flares) - Changed - reverts Suppression chance to accomodate #304 - Removed vanilla attack feature from groups* *This is a big one which we've talked about internally before. What this does is remove the lock-in units sometimes suffer due to the vanilla ATTACK pattern/fsm. I propose to check this on the development version. Our own _group_ level attack patterns are better than the individual vanilla ones. But the AI is a complicated beast. Additional testing should be done. * distance2D to distanceSqr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweaks the early suppression check-- adding height to ensure more reliable suppressing events.
Fixes #296
Fixes missing enableAttack use