Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds better support for MLRS artillery #333

Merged
merged 6 commits into from
Feb 18, 2024

Conversation

nk3nny
Copy link
Owner

@nk3nny nk3nny commented Feb 23, 2023

Improves Dynamic Artillery support for MLRS style launchers.

  • MLRS launchers will now shoot their entire magazine. Launchers with large magazines will still clump their salvos in 2's or 4's to ensure good spread on target.
  • MLRS launchers will have no check rounds-- which make them quite dangerous in numbers.

Improves Dynamic Artillery support for MLRS style launchers.

MLRS launchers will now shoot their entire magazine. Launchers with large magazines will still clump their salvos in 2's or 4's to ensure good spread on target.

MLRS launchers will have no check rounds-- which make them quite dangerous in numbers.
@nk3nny nk3nny self-assigned this Feb 23, 2023
Missing private tag.
Fixed stray double definition
@rautamiekka
Copy link
Contributor

I suppose the idea is to make sure the dynamic target, and everything around it, is gonna die ?

Or is this a bug fix of sorts ?

@diwako
Copy link
Collaborator

diwako commented Feb 24, 2023

I suppose the idea is to make sure the dynamic target, and everything around it, is gonna die ?

Or is this a bug fix of sorts ?

It is a lowkey feature request from someone from our discord server. They are developing MRLS artillery vehicle assets and asked if it was intended for them to shoot only one rocket at a time.
The current code more or less only simulates tube based artillery and is tweaked for gameplay. With this you can mark an artillery as MRLS, so it behaves a bit different and actually uses the rocket/missile salvo as an MRLS would do. Pretty much obliterating a whole area as their original intend is.

@rautamiekka
Copy link
Contributor

Interesting, why not.

@nk3nny
Copy link
Owner Author

nk3nny commented Mar 2, 2023

Remember to add Zeus interaction

Copy link
Collaborator

@jokoho48 jokoho48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zeus Modules and Editor Modules missing. also TaskArtillery has header not updated

Adds description to stringtable
Adds debug information when taskArtillery is shooting.
Removes 'salvo' from parameters (complicated things)
@nk3nny nk3nny dismissed jokoho48’s stale review February 18, 2024 12:08

Salvo variable is no longer configurable in current solution

Move "MLRS" check to taskArtilleryRegister
Remove entries from stringtable
fixes _gun variable
Updated german text
@nk3nny nk3nny merged commit 612a471 into master Feb 18, 2024
4 checks passed
@nk3nny nk3nny deleted the Add-better-MLRS-support-to-Artillery-WP branch February 18, 2024 15:06
@jokoho48 jokoho48 added this to the 2.6.1 milestone Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants