Improve Group and Contact Suppression #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a followup firestate to suppression states Improves interaction with doAssaultMemory (more predictable) Fixes vehicles being part of Contact state
diwako
reviewed
Apr 16, 2023
| [{_this setVariable [QGVAR(forceMove), nil]}, _x, 5 + random 4] call CBA_fnc_waitAndExecute; | ||
| } foreach _units select {getSuppression _x < 0.5}; | ||
| [ | ||
| { |
There was a problem hiding this comment.
Check if unit is dead and restore old unitPos
There was a problem hiding this comment.
Good call. Fixed in latest push.
Added alive check and reset stance on Contact (Assault) Fixed edge case scenario which could lead to infantry assaulting to [0,0,0] Improved timing of Contract (Suppress) and removed some of the debug variables which were being overwritten by 'suppress' regardless.
Removed debug message
Tiny change to rerun linter
False positives increased
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a follow-up fire state to suppression states
Improves interaction with doAssaultMemory (more predictable) Fixes vehicles being part of Contact state