Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yarr as PWA? #48

Closed
2 tasks
einschmidt opened this issue Mar 13, 2021 · 8 comments
Closed
2 tasks

yarr as PWA? #48

einschmidt opened this issue Mar 13, 2021 · 8 comments
Labels
help wanted Contributors & maintainers welcome

Comments

@einschmidt
Copy link

Hi,
I was reading through your rationale and discovered your initial goal:

a desktop application accessible via web browser

That somehow sparked the question and idea to support yarr as a PWA, adding features like:

  • Installable via the webpage
  • Have a dedicated app icon
  • Proper app feeling, not just a webpage in a browser

Checking pages like pwabuilder.com the minimum requirement would be:

  • A manifest file
  • Service Worker scripts

Have you considered making yarr a PWA?

I could help providing the necessary files, but have honestly no idea how to include them via GO.
Anyway, wanted to check with you upfront.

What do you think?

@nkanaev
Copy link
Owner

nkanaev commented Mar 14, 2021

I've long thought whether to add pwa capabilities (maybe overthinking much), but all my concerns boil down to a simple question:

what benefits does it have over the direct browser access?

and to answer the points:

  • installable via the webpage - having a webpage with static content accessible offline is good, but the thin client it's pretty much useless without internet connection.
  • have a dedicated app icon - afaik, the regular websites can be added to homescreen as well (tested on chrome android)
  • proper app feeling, not just a webpage in a browser - benefit of getting rid of browser chrome (not to be confused with the google chrome browser)

summarizing:

  • functional benefits are none/limited.
  • aesthetic benefits on mobile (for self-hosters only)

i'm inclined more towards "no", but i'm open for further discussion.

@einschmidt
Copy link
Author

Fair points. And honestly, can't argue too much against.

Just thought it would be a low hanging fruit to catch, considering the rather minimal effort.

By the way, I am one of these self-hosters seeking for aesthetic benefits on mobile, as you may have guessed. 😸

Despite that, please allow me to share my appreciation in between. Great tool. Love the minimal style. Honestly, I was looking for something like yarr for years. 👍

@nkanaev
Copy link
Owner

nkanaev commented Mar 17, 2021

thanks!

just to clarify, i'm not against pwa per se.
i think yarr'd work great as an application shell.
though i'm not sure how to handle the index page caching,
given that it's used both as the main interface and the login page.

if the implementation is fairly simple, then go for it.
i'm happy to pick it up for v2.

@nkanaev nkanaev added the help wanted Contributors & maintainers welcome label Apr 5, 2021
@nkanaev
Copy link
Owner

nkanaev commented Apr 22, 2021

closing the ticket due to lack of interest from others. happy to reopen it if anyone is willing to implement & support it.

@nkanaev nkanaev closed this as completed Apr 22, 2021
@JadeVane
Copy link

Another interest here.

What I most interest in is the proper app feeling, it means that there is no any annoying address bar when I am reading, so the address bar will be disapear which make me focus on what I want.

Actually, I know what you are worrying about, keep it simple and just act what a great rss reader would be is the best thing that yarr ever do, BTW, this is what I have been looking for a long time, as @einschmidt said, for years, thank you sincerely for developing yarr.

@thanhnguyen2187
Copy link

Hi @einschmidt. I think I can work on this. Can you provide the files and sketch me a general strategy on implementing service workers?

@einschmidt
Copy link
Author

Hi @thanhnguyen2187 ,

Thank you for your interest. Unfortunately, I am out of time, and never had a deep knowledge of service workers.
For what I can provide though, just check the link provided in the first post. pwabuilder helped gaining some understanding at least.
I bet there are other sources online.
Good luck.

@thanhnguyen2187
Copy link

Hi @einschmidt. I created a PR for PWA. You can also try using my fork and see if there is anything else I miss. Many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Contributors & maintainers welcome
Projects
None yet
Development

No branches or pull requests

4 participants