Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React 17.x support please #137

Closed
cgmack opened this issue May 19, 2021 · 7 comments
Closed

React 17.x support please #137

cgmack opened this issue May 19, 2021 · 7 comments

Comments

@cgmack
Copy link

cgmack commented May 19, 2021

When installing react-debounce-input in my react 17.0.1 project, I get the following error. It appears that react-debounce-input@3.2.3 is limited to react@"^15.3.0 || ^16.0.0". Is there something preventing 17.x support? Is there a timeline for this support? Thank you.

$ npm i --save react-debounce-input
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: frontend@0.1.0
npm ERR! Found: react@17.0.2
npm ERR! node_modules/react
npm ERR!   react@"^17.0.1" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^15.3.0 || ^16.0.0" from react-debounce-input@3.2.3
npm ERR! node_modules/react-debounce-input
npm ERR!   react-debounce-input@"*" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
@nkbt
Copy link
Owner

nkbt commented May 19, 2021

It should work with any modern React version. Just need to add 17 to peer deps

Meanwhile you can use --force, or --legacy-peer-deps to get it installed.

@cgmack
Copy link
Author

cgmack commented May 19, 2021

Great. Thanks for confirming.

@Berend-Kalberg
Copy link

Second this. Has not been fixed yet. Came here to confirm if it still works because its a great tool.

@iMoses-Apiiro
Copy link

iMoses-Apiiro commented Jun 10, 2021

It should work with any modern React version. Just need to add 17 to peer deps

@nkbt Can you please add it and push a new patch version?

jschaffer-edr added a commit to jschaffer-edr/react-debounce-input that referenced this issue Jul 7, 2021
@jschaffer-edr
Copy link
Contributor

Added PR #142

@char0n
Copy link

char0n commented Jul 17, 2021

Cool, any ETA for a release?

@nkbt
Copy link
Owner

nkbt commented Jul 20, 2021

Screen Shot 2021-07-20 at 12 09 54

@nkbt nkbt closed this as completed Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants