Add notifyOnTouchEnd property to trigger notify on touchEnd if the user didn't scroll
#15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 20, 2016 16:22
Fixed bug on IOS (chrome and mobile safari) that saved a reference to the first touch, by the time the touchend event was triggered, the touch object had been mutated by the browser so the diff in coordinates was always 0.
…nd` and don't use `click` for non-touch devices, only `mousedown`
andysprout
changed the title
notifyOnTouchEnd property to trigger notify on touchEnd if the user didn't scroll
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Real pain with mobile safari not bubbling click events.
In the example, if
notifyOnTouchEndis set, when scrolling or zooming on a touch device, the modal is not dismissed.Also use
NODE_HOSTandNODE_PORTenv vars to allow testing on other devices on the same LAN.