Fix return code for getrelay channel request when no modules

nkh-lab · Feb 18, 2024 · 824b785 · 824b785
1 parent 3132f75
commit 824b785
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 2 deletions.
diff --git a/app-cli/src/GetRelayWorker.cpp b/app-cli/src/GetRelayWorker.cpp
@@ -120,7 +120,7 @@ std::string GetRelayWorker::DoBadArgumentText(const std::string& bad_arg)
 
 bool GetRelayWorker::GetState(const std::string& module, int channel, std::string& out)
 {
-    bool ret = true;
+    bool ret = false;
     out = TextUserInterface::kNoModules;
     auto modules = relay_manager_->GetModules();
 

diff --git a/app-cli/tests/unit/GetRelayWorkerTest.cpp b/app-cli/tests/unit/GetRelayWorkerTest.cpp
@@ -247,7 +247,26 @@ TEST_F(GetRelayWorkerTest, NoArgsNoModules)
     bool ret = worker.Run(argc, argv, out);
 
     EXPECT_EQ(out, std::string{TextUserInterface::kNoModules});
-    EXPECT_TRUE(ret);
+    EXPECT_FALSE(ret);
+}
+
+TEST_F(GetRelayWorkerTest, RequestChannelNoModules)
+{
+    const char* argv[] = {"", "module2_2"};
+    int argc = ARRAY_SIZE(argv);
+
+    // Mocking
+    EXPECT_CALL(*relay_manager_, GetModules()).Times(1).WillOnce(Return(relay_modules_size0_));
+    //========
+
+    GetRelayWorker worker(std::move(relay_manager_));
+
+    std::string out;
+
+    bool ret = worker.Run(argc, argv, out);
+
+    EXPECT_EQ(out, std::string{TextUserInterface::kNoModules});
+    EXPECT_FALSE(ret);
 }
 
 TEST_F(GetRelayWorkerTest, NoArgsOneModule)