Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install pyOpenSSL package more dynamically #25

Merged
merged 2 commits into from
Mar 5, 2021

Conversation

spoore1
Copy link
Collaborator

@spoore1 spoore1 commented Jan 21, 2020

RHEL8 cannot install the python3 version of pyOpenSSL with that name.
You must use "python3-pyOpenSSL" to install for RHEL8.

Adding a fact to python_2_3_test.yml to define which package name to
use for pyOpenSSL: keycloak_dep_pyOpenSSL

Changing package install for dependencies to use the fact that we set
in the python_2_3_test.yml task.

Resolves: issue #24

#24

RHEL8 cannot install the python3 version of pyOpenSSL with that name.
You must use "python3-pyOpenSSL" to install for RHEL8.

Adding a fact to python_2_3_test.yml to define which package name to
use for pyOpenSSL:  keycloak_dep_pyOpenSSL

Changing package install for dependencies to use the fact that we set
in the python_2_3_test.yml task.

Resolves: issue nkinder#24

nkinder#24
@nkinder
Copy link
Owner

nkinder commented Jan 22, 2020

CI is currently failing due to this issue:

#22

@spoore1 spoore1 force-pushed the rhel8_pyopenssl branch 13 times, most recently from 62b25cd to cef0ca0 Compare January 23, 2020 02:41
@spoore1
Copy link
Collaborator Author

spoore1 commented Jan 23, 2020

@nkinder
I tried a few different workarounds but so far none have solved the issue on all three platforms.

I think downgrading and version locking may be the only solution until it's fixed. I tried a manual downgrade but, that didn't work either. Now F29 is the failing version that the workaround doesn't seem to work on.

Question though, should we still be testing Fedora 28 and 29? Or should we be on 30 and 31?

@nkinder
Copy link
Owner

nkinder commented Jan 23, 2020

Question though, should we still be testing Fedora 28 and 29? Or should we be on 30 and 31?

Good call. We should move up to Fedora 30 and 31.

@spoore1 spoore1 force-pushed the rhel8_pyopenssl branch 4 times, most recently from 301b43c to 7041b57 Compare January 23, 2020 14:28
@spoore1
Copy link
Collaborator Author

spoore1 commented Jan 23, 2020

Ok, so my second commit seems to work around the failure in issue #22

The question now is do we really want to keep that or just keep the update to Fedora 30 and 31?

Attempting to work around CI failures from issue nkinder#22.

Also moving test distros from Fedora 28 and 29 to 30 and 31.

TODO: remove workaround when distros fixed

Firewalld Issue: firewalld/firewalld#519
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1754029
@spoore1
Copy link
Collaborator Author

spoore1 commented Jan 23, 2020

If the workaround is only needed for CentOS7, it would be nice to only use the workaround for that CI platform. I won't block on this if it can't be done easily though. Also, mark this with a TODO to remove it once the issue is fixed in CentOS7 and use a real link to the actual firewalld issue.

It looks like it affects Fedora 30 and 31 as well with a fix waiting in rawhide for 32. I asked in the firewall issue if it would make it in sooner.

I also updated the Dockerfile template and commit message in the update here:

254eba0

Is there a way to mark the PR with a TODO? I don't see a label for it now.

@spoore1
Copy link
Collaborator Author

spoore1 commented Feb 22, 2021

@nkinder should I update travis/molecule to fedora 32/33 here and check that the workaround to the firewall issue is no longer needed before merging this? I'm guessing that is no longer needed but, I'm not 100% sure.

@nkinder nkinder merged commit c47506d into nkinder:master Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants