Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use --mode argument to be consistent with Vue CLI #1626

Open
undergroundwires opened this issue Dec 28, 2021 · 2 comments
Open

Use --mode argument to be consistent with Vue CLI #1626

undergroundwires opened this issue Dec 28, 2021 · 2 comments

Comments

@undergroundwires
Copy link

undergroundwires commented Dec 28, 2021 •
edited

Vue CLI uses --mode argument to set NODE_ENV however we do the opposite here.

It would be nice to be part of Vue convention, this way users can except similar behavior to npm run electron:build just like npm run build and set the environment in a unified consistent way.

It would also simplify understanding of how vue-cli-service build is called internally.

Unidentical APIs also cause a bug/limitation like #1627
@undergroundwires undergroundwires mentioned this issue Dec 28, 2021
Open
undergroundwires added a commit to undergroundwires/privacy.sexy that referenced this issue Dec 29, 2021
@undergroundwires
Add build checks and improve existing CI/CD checks
9f044d9 
Run quality checks for every possible OS because behavior of linting
rules may change per OS (e.g. `linebreak-style` ESLint assertment varies
by Unix-like vs Windows).

Add a new check to ensure project can be built:
  1. As both web and desktop applications.
    Different jobs are used due to nonidentical environment/mode support.
    Reference: nklayman/vue-cli-plugin-electron-builder#1627.
  2. Targeting all possible modes.
    The modes are configured using `--mode` but electron CLI checks
    `NODE_ENV` so it's set as well.
    Reference: nklayman/vue-cli-plugin-electron-builder#1626.

  3. On and for different operating systems.

Fix typo "Run units" instead of "Run unit tests".

Link to specific GitHub actions page for workflow runs.

Update documentation to match new structure, and change nontransparent
icons from the diagram and consistently use imperative for actions.

Rename `release-site` , `release-git`, `release-desktop` to
`site-release` , `git-release` and `desktop-release` to not be Yoda.
undergroundwires added a commit to undergroundwires/privacy.sexy that referenced this issue Dec 29, 2021
@undergroundwires
Add build checks and improve existing CI/CD checks
ef2fcaa 
Run quality checks for every possible OS because behavior of linting
rules may change per OS (e.g. `linebreak-style` ESLint assertment varies
by Unix-like vs Windows).

Add a new check to ensure project can be built:
  1. As both web and desktop applications.
    Different jobs are used due to nonidentical environment/mode support.
    Reference: nklayman/vue-cli-plugin-electron-builder#1627.
  2. Targeting all possible modes.
    The modes are configured using `--mode` but electron CLI checks
    `NODE_ENV` so it's set as well.
    Reference: nklayman/vue-cli-plugin-electron-builder#1626.

  3. On and for different operating systems.

Fix typo "Run units" instead of "Run unit tests".

Link to specific GitHub actions page for workflow runs.

Update documentation to match new structure, and change nontransparent
icons from the diagram and consistently use imperative for actions.

Rename `release-site` , `release-git`, `release-desktop` to
`site-release` , `git-release` and `desktop-release` to not be Yoda.
undergroundwires added a commit to undergroundwires/privacy.sexy that referenced this issue Dec 30, 2021
@undergroundwires
Add build checks and improve existing CI/CD checks
17298f0 
Run quality checks for every possible OS because behavior of linting
rules may change per OS (e.g. `linebreak-style` ESLint assertment varies
by Unix-like vs Windows).

Add a new check to ensure project can be built:
  1. As both web and desktop applications.
    Different jobs are used due to nonidentical environment/mode support.
    Reference: nklayman/vue-cli-plugin-electron-builder#1627.
  2. Targeting all possible modes.
    The modes are configured using `--mode` but electron CLI checks
    `NODE_ENV` so it's set as well.
    Reference: nklayman/vue-cli-plugin-electron-builder#1626.

  3. On and for different operating systems.

Fix typo "Run units" instead of "Run unit tests".

Link to specific GitHub actions page for workflow runs.

Update documentation to match new structure, and change nontransparent
icons from the diagram and consistently use imperative for actions.

Rename `release-site` , `release-git`, `release-desktop` to
`site-release` , `git-release` and `desktop-release` to not be Yoda.
@nklayman
Copy link
Owner

nklayman commented Jan 6, 2022

I'm not sure what you mean by "we do the opposite here," can you elaborate a bit more?

@undergroundwires
Copy link
Author

I'm sorry for my bad formulation.

Vue CLI uses --mode to set NODE_ENV for e.g. webpack.

vue-cli-plugin-electron-builder uses NODE_ENV to set --mode.

A code snippet example I found is here.

So as a workaround, I set both:

mode='production'
npm install --global cross-env
cross-env-shell NODE_ENV="$mode"
npm run electron:build -- --publish never --mode "$mode"

But it would be nice to be able to skip setting NODE_ENV environment variable and rely on --mode only.

LarrMarburger pushed a commit to LarrMarburger/privacy.sexy that referenced this issue Nov 16, 2023
@undergroundwires
Add build checks and improve existing CI/CD checks
08b531f 
Run quality checks for every possible OS because behavior of linting
rules may change per OS (e.g. `linebreak-style` ESLint assertment varies
by Unix-like vs Windows).

Add a new check to ensure project can be built:
  1. As both web and desktop applications.
    Different jobs are used due to nonidentical environment/mode support.
    Reference: nklayman/vue-cli-plugin-electron-builder#1627.
  2. Targeting all possible modes.
    The modes are configured using `--mode` but electron CLI checks
    `NODE_ENV` so it's set as well.
    Reference: nklayman/vue-cli-plugin-electron-builder#1626.

  3. On and for different operating systems.

Fix typo "Run units" instead of "Run unit tests".

Link to specific GitHub actions page for workflow runs.

Update documentation to match new structure, and change nontransparent
icons from the diagram and consistently use imperative for actions.

Rename `release-site` , `release-git`, `release-desktop` to
`site-release` , `git-release` and `desktop-release` to not be Yoda.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nklayman @undergroundwires