Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate Fonts in Bundle only on electron:build #694

Closed
Clocktown opened this issue Mar 27, 2020 · 1 comment
Closed

Duplicate Fonts in Bundle only on electron:build #694

Clocktown opened this issue Mar 27, 2020 · 1 comment

Comments

@Clocktown
Copy link

Clocktown commented Mar 27, 2020

Describe the bug
npm run electron:build duplicates local fonts, creating a bundle that contains them in fonts as well as in css/fonts. This also results in a larger asar package.

To Reproduce

vue create my-project
cd my-project
vue add electron-builder
npm install roboto-fontface

And then add import "roboto-fontface/css/roboto/roboto-fontface.css" to src/main.js

Expected behavior
Should produce the same bundle that npm run build does, which only contains the fonts in the fonts folder.

Environment:

  • OS and version: Windows 10
  • node version: v12.16.1
  • npm version: 6.13.4
  • vue-cli-plugin-electron-builder version : vue-cli-plugin-electron-builder@1.4.6
  • electron version: ^6.0.0
@nklayman
Copy link
Owner

I added the duplication a few years ago because I was having font import errors on electron:build. Since the error appears to have disappeared now, I have removed the duplication in the 2.0.0 beta as it could possibly be a breaking change.

thislooksfun pushed a commit to thislooksfun/vue-cli-plugin-electron-builder that referenced this issue Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants