Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use EditorSettings instead of ProjectSettings. #19

Closed
rylydou opened this issue Oct 14, 2023 · 3 comments
Closed

Use EditorSettings instead of ProjectSettings. #19

rylydou opened this issue Oct 14, 2023 · 3 comments

Comments

@rylydou
Copy link

rylydou commented Oct 14, 2023

Most of settings for this addon seam to be only for the paths to executables. Using Editor Settings instead of Project Settings would work better for teams who use different operating systems.

I think it should be as simple as replacing every instance of ProjectSettings with EditorSettings in project_setting.gd.

@rylydou
Copy link
Author

rylydou commented Oct 14, 2023

I will try this change in my project and let you know if there are any problems.

@nklbdev
Copy link
Owner

nklbdev commented Oct 15, 2023

Thanks, that's a good point. I will also try to transfer the Importality settings to the editor settings.

I'm really sorry, but I couldn't devote time to this project this week because I'm very busy at work. I'll try the next one.

@nklbdev
Copy link
Owner

nklbdev commented Oct 16, 2023

I tried moving the plugin settings from ProjectSettings to EditorSettings. I think I succeeded, although there were some minor pitfalls.

Please test the latest version of the use_editor_settings_instead_of_project_settings branch on your project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants