GH-22: Fix zwave_command_class_node_info_resolver unit test #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SiliconLabsGH-22 add a new callback on the give_up_listener on the ATTRIBUTE_ZWAVE_SECURE_NIF attribute causing the test case to fail. The test only expect this listener to be called on the non-secure NIF ATTRIBUTE_ZWAVE_NIF. This change make sure that the code is only executed in the context of ATTRIBUTE_ZWAVE_NIF and ignored for ATTRIBUTE_ZWAVE_SECURE_NIF as this test don't care about it. Bug-SiliconLabs: UIC-3082 Relate-to: SiliconLabs#22 Forwarded-SiliconLabs: task/UIC-3082/phcoval/SiliconLabsGH-22/develop
|
Please merge if you like the proposed change and it will land in upcoming release |
|
Feedback welcome, if no objection we will probably merge this downstream |
Bug-SiliconLabs: UIC-3082 Relate-to: SiliconLabs#22 Forwarded-SiliconLabs: task/UIC-3082/phcoval/SiliconLabsGH-22/develop Origin: #2 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
silabs-borisl
force-pushed
the
fix-mc-secure-nif
branch
from
9237826
to
92ea570
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SiliconLabsGH-22 add a new callback on the give_up_listener on the ATTRIBUTE_ZWAVE_SECURE_NIF attribute causing the test case to fail.
The test only expect this listener to be called on the non-secure NIF ATTRIBUTE_ZWAVE_NIF. This change make sure that the code is only executed in the context of ATTRIBUTE_ZWAVE_NIF and ignored for ATTRIBUTE_ZWAVE_SECURE_NIF as this test don't care about it.
Bug-SiliconLabs: UIC-3082
Relate-to: SiliconLabs#22
Forwarded-SiliconLabs: task/UIC-3082/phcoval/SiliconLabsGH-22/develop
Change
Checklist