update version of comment-patterns dependency #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
|
Sorry, one more change needed to ultimately use the php multi-line comments. |
|
👋 |
|
I still need an approval on this one |
|
sorry for the delay. I have my mind full with other stuff. I added you as collaborator... will add you at npm as well |
|
No worries! Thanks for merging!!!
…On Mon, Oct 22, 2018 at 13:06 Nils Knappmeier ***@***.***> wrote:
sorry for the delay. I have my mind full with other stuff. I added you as
collaborator... will add you at npm as well
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#10 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAla6lWiitLmwnqNgWzxq--DDb56r0_Mks5uniVhgaJpZM4XI5JF>
.
|
|
It still needs to be published, maybe you can try that. |
|
Looks published to me. Did you take care of it?
…On Mon, Oct 22, 2018 at 13:57 Nils Knappmeier ***@***.***> wrote:
It still needs to be published, maybe you can try that.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#10 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAla6gl8iP_GBmAmQJPLLMkjMowJ7OI-ks5unjFMgaJpZM4XI5JF>
.
|
|
No, and npmjs.com states that the last publish was 2 years ago. |
|
Ah I see that...but does have the correct version displayed 0.3.0....so
maybe it will resolve itself?
…On Tue, Oct 23, 2018 at 12:34 Nils Knappmeier ***@***.***> wrote:
No, and npmjs.com
<https://www.npmjs.com/package/multilang-extract-comments> states that
the last publish was 2 years ago.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#10 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAla6q807lFPg4veo0o5eqnFX-yHY-NSks5un29KgaJpZM4XI5JF>
.
|
|
Ah, no. should do the trick. |
|
Got it! Thanks!
…On Tue, Oct 23, 2018 at 12:59 PM Nils Knappmeier ***@***.***> wrote:
Ah, no. 0.3.0 is still the old version. If you want to publish, you have
to increase it.
npm version minor
npm publish
git push --tags
should do the trick.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#10 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAla6oeowQ6tJ53CRdhKbXks4Nd3xEsGks5un3UQgaJpZM4XI5JF>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will now use the updated version of the comment-patterns repo.