Support for Handlebars.SafeString #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 similar comments
1 similar comment
- Add "replaceP" as replacement for "String.prototype.replace" with promise support. - Use "replaceP" in Marker to replace placeholders by actual values.
Closed
…(createrMarkerClass-function with Promise-constructor as argument) Include extract "lib/*"-files into Extract utility functions to separate file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves #25.
promisedHandlebarseturns the correct result for a test-case derived from the one in #22).It would be nice if someone could review this and give comments. If nobody says a word, I will merge and publish next week (probably on Tuesday) to give some time for reviews.
Basically, the solution is to implement special behavior for Promises and SafeStrings in the
replacePlaceholdersRecursivelyIn-function. This also caused the need for aString.prototype.replace-alternative that is capable for handling Promises returned from the replacer-function.This is implemented in a separate file (and could possibly be extracted into a separate npm-module).