Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depending on 'trace-and-clarify-if-possible' throws error on Node 8 #3

Closed
igor-savin-ht opened this issue Jan 9, 2018 · 9 comments
Closed

Comments

@igor-savin-ht
Copy link

Since 'trace' is defined as a dependency in this library, it gets resolved transitively for whoever depends on it, and on Node.js 8 this results in

error trace@2.4.1: The engine "node" is incompatible with this module. Expected version "^4.5 || ^6.0 || ^7.0".

Probably this can be resolved by changing trace dependency to peerDependency - this will also allow whoever consumes this library to also provide a different major release of trace, that is compatible with Node 8 (if version range would allow >2.x.y version)

@nknapp
Copy link
Owner

nknapp commented Jan 9, 2018

Would "optionalDependency" work?

@nknapp
Copy link
Owner

nknapp commented Jan 9, 2018

Another option would be a npm "install" script that installs the correct version of "trace" based on the current node version.

@igor-savin-ht
Copy link
Author

"If a dependency can be used, but you would like npm to proceed if it cannot be found or fails to install, then you may put it in the optionalDependencies object"

Worth a shot, I guess :)

@igor-savin-ht
Copy link
Author

Would npm install script work properly when 'trace-and-clarify-if-possible' is a transitive dependency?

@nknapp
Copy link
Owner

nknapp commented Jan 9, 2018

I think so. If not, "postinstall" should work.

@igor-savin-ht
Copy link
Author

Then it makes sense.

nknapp added a commit that referenced this issue Jan 9, 2018
closes #3

- trace and clarify are now optional dependencies which which means that
  they are not installed on node 8
@nknapp nknapp closed this as completed in 7997a00 Jan 9, 2018
@igor-savin-ht
Copy link
Author

igor-savin-ht commented Jan 9, 2018

@nknapp Any chance you could release new version to npm and also new version of bootprint that would depend on it?

@nknapp
Copy link
Owner

nknapp commented Jan 9, 2018

I have just release version 1.0.2 which should resolve this problem and some other errors.

@igor-savin-ht
Copy link
Author

Thanks! I'll give it a spin tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants