-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Depending on 'trace-and-clarify-if-possible' throws error on Node 8 #3
Comments
Would "optionalDependency" work? |
Another option would be a npm "install" script that installs the correct version of "trace" based on the current node version. |
"If a dependency can be used, but you would like npm to proceed if it cannot be found or fails to install, then you may put it in the optionalDependencies object" Worth a shot, I guess :) |
Would npm install script work properly when 'trace-and-clarify-if-possible' is a transitive dependency? |
I think so. If not, "postinstall" should work. |
Then it makes sense. |
closes #3 - trace and clarify are now optional dependencies which which means that they are not installed on node 8
@nknapp Any chance you could release new version to npm and also new version of bootprint that would depend on it? |
I have just release version 1.0.2 which should resolve this problem and some other errors. |
Thanks! I'll give it a spin tomorrow. |
Since 'trace' is defined as a dependency in this library, it gets resolved transitively for whoever depends on it, and on Node.js 8 this results in
Probably this can be resolved by changing trace dependency to peerDependency - this will also allow whoever consumes this library to also provide a different major release of trace, that is compatible with Node 8 (if version range would allow >2.x.y version)
The text was updated successfully, but these errors were encountered: