Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC for resolving registered names #327

Merged
merged 1 commit into from
Oct 8, 2018
Merged

Conversation

trueinsider
Copy link
Contributor

Proposed changes in this pull request

Added new RPC call to resolve registered name to wallet address. This would allow to support names not only in client but in wallets too.

Usage example:
{"jsonrpc":"2.0","method":"getaddressbyname","params":{"name":"registeredname"}}

Type

  • Bug fix: Link to the issue
  • Feature (Non-breaking change)
  • Feature (Breaking change)
  • Documentation Improvement

Checklist

  • Read the CONTRIBUTION guidelines.
  • All the tests are passing after the introduction of new changes.
  • Added tests respective to the part of code I have written.
  • Added proper documentation where ever applicable (in code and README.md).
  • Code has been written according to NKN-Golang-Style-Guide

@yilunzhang
Copy link
Member

Looks good to me

Copy link
Member

@gdmmx gdmmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too.

@yilunzhang yilunzhang merged commit a754443 into nknorg:master Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants