Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dictionary Site #21

Closed
ijemmao opened this issue Sep 27, 2020 · 13 comments
Closed

Dictionary Site #21

ijemmao opened this issue Sep 27, 2020 · 13 comments
Labels
enhancement New feature or request

Comments

@ijemmao
Copy link
Collaborator

ijemmao commented Sep 27, 2020

Create a quick site that uses the API and displays the results.

@ijemmao ijemmao added the enhancement New feature or request label Sep 27, 2020
@ijemmao ijemmao added this to To do in Igbo Dictionary API Sep 27, 2020
@C-Zekeri
Copy link

C-Zekeri commented Oct 3, 2020

Hi @ijemmao I'd love to work on this issue. Anything I should know before getting started?

@ijemmao
Copy link
Collaborator Author

ijemmao commented Oct 3, 2020

Hi @ijemmao I'd love to work on this issue. Anything I should know before getting started?

Amazing! Yeah, there's a few things that I was considering for this ticket:

  • Use Gatsby to build the site - this will make it easier to customize the site and interface with the API
  • Keep it in this repo - So the front-facing site code would live on it's own branch in this repo
  • Use a CSS utility framework like Tailwind to keep everything looking consistent
  • Follow the look of Jisho where the search bar is on the home page, and then once you enter the term, you will get back it's word class, definition, phrases, and their examples.

These bullets are super high-level and there's definitely a ton of details that need to be worked out, so please let me know if you have any questions. I recommend creating smaller tickets that focus on a particular part of building out the front-site so others can help out.

@C-Zekeri
Copy link

C-Zekeri commented Oct 3, 2020

Ah. I've never actually worked with Gatsby before, so if that's a requirement I'm not sure I'll be able to pitch in.
Thank you 🤗

@ijemmao
Copy link
Collaborator Author

ijemmao commented Oct 4, 2020

Ah. I've never actually worked with Gatsby before, so if that's a requirement I'm not sure I'll be able to pitch in.
Thank you 🤗

@C-Zekeri A lot of this is still up the air, so if there's a framework that you prefer using you can suggest it. But if you're not feeling up to it no worries! You can still put in feature requests for the API!

@C-Zekeri
Copy link

C-Zekeri commented Oct 4, 2020

Alright then. On second thought, since I have a bit of React knowledge, I'd be willing to learn Gatsby for the project. The only thing is I might take a bit more time, but if you don't mind that, then I'll be glad to do so.

@ijemmao
Copy link
Collaborator Author

ijemmao commented Oct 4, 2020

@C-Zekeri nice! In order to make this more manageable, I recommend making super small issues that break up the work that your going to be completing.

So a good first issue would be to create a new branch that's dedicated to the source code to hold the site and set up a basic Gatsby project there.

@C-Zekeri
Copy link

C-Zekeri commented Oct 6, 2020

Alright, will get on it, thank you very much.

@C-Zekeri
Copy link

C-Zekeri commented Oct 6, 2020

Hi @ijemmao. Are we also including an about page, or the lone home page with search results linking to a detail page?

@ijemmao
Copy link
Collaborator Author

ijemmao commented Oct 6, 2020

Hi @ijemmao. Are we also including an about page, or the lone home page with search results linking to a detail page?

You can include an about page but we'll have to discuss on your PR what makes sense to be on the about page. I think what would be better if you separated the about page out to its own PR.

I also set up a really basic Gatsby site on my local branch, I can push my code and you could start iterating from it.

You should see a gatsby-dev site in this repo that you can pull from.

@C-Zekeri
Copy link

C-Zekeri commented Oct 6, 2020

Great. Thank you!

@Mancancode
Copy link
Contributor

Hello I will be working on enhancing the frontend, my first step will make the search button to look for welcoming.

@ijemmao ijemmao changed the title Front Facing Site Dictionary Site Oct 17, 2020
@ijemmao
Copy link
Collaborator Author

ijemmao commented Oct 17, 2020

@Mancancode awesome! Could you create an issue that details what you're going to do exactly, and I can officially assign you to that ticket?

@ijemmao
Copy link
Collaborator Author

ijemmao commented Nov 17, 2020

Closing this ticket since it's outdated and a good portion of what's been mentioned in this thread has been completed.

@ijemmao ijemmao closed this as completed Nov 17, 2020
Igbo Dictionary API automation moved this from To do to Done Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

3 participants