Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve code]: astro/src/components/Client/bsky/* 手動formatter・Linter対応 #55

Closed
27 tasks done
nkte8 opened this issue Mar 31, 2024 · 1 comment · Fixed by #83
Closed
27 tasks done

[Improve code]: astro/src/components/Client/bsky/* 手動formatter・Linter対応 #55

nkte8 opened this issue Mar 31, 2024 · 1 comment · Fixed by #83
Assignees
Labels
invalid This doesn't seem right

Comments

@nkte8
Copy link
Owner

nkte8 commented Mar 31, 2024

Where and how it seems bad?

astro/src/components/Client/bsky/* 配下のコードへの対応。
複数人で対応する場合は、作業範囲が被らないようブランチ名に対応ファイルを記載するなどの対応をすること。

  • : astro/src/components/Client/bsky/buttons/AddImageButton.tsx
  • : astro/src/components/Client/bsky/buttons/DraftSaveButton.tsx
  • : astro/src/components/Client/bsky/buttons/LinkcardAttachButton.tsx
  • : astro/src/components/Client/bsky/buttons/LogoutButton.tsx
  • : astro/src/components/Client/bsky/buttons/PostButton.tsx
  • : astro/src/components/Client/bsky/lib/addImageMediaData.ts
  • : astro/src/components/Client/bsky/lib/loadProfile.ts
  • : astro/src/components/Client/bsky/lib/saveTagList.ts
  • : astro/src/components/Client/bsky/MediaPreview/AltDialog.tsx
  • : astro/src/components/Client/bsky/MediaPreview/DeleteItemButton.tsx
  • : astro/src/components/Client/bsky/MediaPreview/index.tsx
  • : astro/src/components/Client/bsky/MediaPreview/MetaView.tsx
  • : astro/src/components/Client/bsky/optionToggles/AppendViaToggle.tsx
  • : astro/src/components/Client/bsky/optionToggles/AutoXPopupToggle.tsx
  • : astro/src/components/Client/bsky/optionToggles/ForceIntentToggle.tsx
  • : astro/src/components/Client/bsky/optionToggles/NoGenerateToggle.tsx
  • : astro/src/components/Client/bsky/optionToggles/SavePasswordToggle.tsx
  • : astro/src/components/Client/bsky/optionToggles/ShowTaittsuuToggle.tsx
  • : astro/src/components/Client/bsky/selectLists/LanguageSelectList.tsx
  • : astro/src/components/Client/bsky/selectLists/SelfLabelsSelectList.tsx
  • : astro/src/components/Client/bsky/unique/DraftDialog.tsx
  • : astro/src/components/Client/bsky/unique/LoadSession.tsx
  • : astro/src/components/Client/bsky/unique/TagInputList.tsx
  • : astro/src/components/Client/bsky/unique/TextInputBox.tsx
  • : astro/src/components/Client/bsky/LoginForm.tsx
  • : astro/src/components/Client/bsky/PostForm.tsx
  • : astro/src/components/Client/bsky/types.ts

What it shoud become?

#38 の対応に伴い、フォーマッタ/Linterの対応を実施すること。

@nkte8 nkte8 added the invalid This doesn't seem right label Mar 31, 2024
@nkte8 nkte8 changed the title [Improve code]: components/Client 手動formatter・Linter対応 [Improve code]: components/Client/* 手動formatter・Linter対応 Mar 31, 2024
@nkte8 nkte8 changed the title [Improve code]: components/Client/* 手動formatter・Linter対応 [Improve code]: astro/src/components/Client/bsky/* 手動formatter・Linter対応 Mar 31, 2024
@ZEKE320 ZEKE320 self-assigned this Apr 7, 2024
@nkte8
Copy link
Owner Author

nkte8 commented Apr 12, 2024

対応完了、ありがとうございました!

@nkte8 nkte8 closed this as completed Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants