Fix/#42 fix installation files #137

GewoonMaarten · 2021-04-17T11:23:57Z

In this pull request we changed the following to the repository and build process:

Changed every component.tsx to index.tsx, this allows us to import directly (e.g. import FormControl from '@gemeente-denhaag/formcontrol' instead of @gemeente-denhaag/formcontrol/FormControl').
Every component is build with the typescript transpiler to the target es5
Each storybook story is moved to their component folder in src/components/ - This was necessary since each component now outputs javascript and storybook cannot infer types from this to autogenerate documentation.
Added react as peer dependency to every component
Storybook stories refer to local packages, so make sure to do a yarn build before yarn storybook
Upgraded react and storybook to their latest version (in all package.jsons)

Also closes PR #114, #113 and #131

Testing
We have tested this using a verdaccio local registry on the PWA master and development branches.
This can be repeated by installing and running verdaccio on the default port, navigate to http://localhost:4873 and follow instructions to login on the registry, username, password and email do not matter.
If you have used verdaccio before, remove the content in the verdaccio/storage folder.

A lerna publish will create and push tags to your remote.
In order to test this without publishing tags and commits to the denhaag origin, create a dummy github repository and set your git remote origin to it temporarily.
Make sure the tags that are created on publish don't exist yet in the local git registry, otherwise remove them locally: git tag | xargs git tag -d

Run the following command to publish a new version to the local registry (on a separate branch e.g. fix/test):
lerna publish --registry http://localhost:4873 --allow-branch fix/test --skip-git

Now you can test the packages in a new React project, or test it in the PWA. Either way make sure you specify the registry with --registry http://localhost:4873.
In the PWA yarn upgrade the dependency of @gemeente-denhaag/denhaag-component-library (with the registry flag), and correct the imports.

GH config changes and updated project README.md

Sprint 5

Sprint 6 merge 1

Renamed all files to index.tsx and moved into src directory. This is to be inline with conventions.

Sprint 7 merge 1

- @gemeente-denhaag/accordionactions@0.1.7 - @gemeente-denhaag/accordiondetails@0.1.7 - @gemeente-denhaag/accordionsummary@0.1.7 - @gemeente-denhaag/accordion@0.1.7 - @gemeente-denhaag/appbar@0.1.7 - @gemeente-denhaag/avatargroup@0.1.7 - @gemeente-denhaag/avatar@0.1.7 - @gemeente-denhaag/badge@0.1.7 - @gemeente-denhaag/basedatadisplayprops@0.1.7 - @gemeente-denhaag/baselayoutprops@0.1.7 - @gemeente-denhaag/baseprops@0.1.7 - @gemeente-denhaag/box@0.1.7 - @gemeente-denhaag/buttongroup@0.1.7 - @gemeente-denhaag/button@0.1.7 - @gemeente-denhaag/cardactions@0.1.7 - @gemeente-denhaag/cardcontent@0.1.7 - @gemeente-denhaag/cardheader@0.1.7 - @gemeente-denhaag/card@0.1.7 - @gemeente-denhaag/checkbox@0.1.7 - @gemeente-denhaag/container@0.1.7 - @gemeente-denhaag/divider@0.1.7 - @gemeente-denhaag/drawer@0.1.7 - @gemeente-denhaag/formcontrollabel@0.1.7 - @gemeente-denhaag/formcontrol@0.1.7 - @gemeente-denhaag/formgroup@0.1.7 - @gemeente-denhaag/gridlisttilebar@0.1.7 - @gemeente-denhaag/gridlisttile@0.1.7 - @gemeente-denhaag/gridlist@0.1.7 - @gemeente-denhaag/grid@0.1.7 - @gemeente-denhaag/hidden@0.1.7 - @gemeente-denhaag/iconbutton@0.1.7 - @gemeente-denhaag/inputlabel@0.1.7 - @gemeente-denhaag/link@0.0.2 - @gemeente-denhaag/listitemavatar@0.1.7 - @gemeente-denhaag/listitemicon@0.1.7 - @gemeente-denhaag/listitemsecondaryaction@0.1.7 - @gemeente-denhaag/listitemtext@0.1.7 - @gemeente-denhaag/listitem@0.1.7 - @gemeente-denhaag/listsubheader@0.1.7 - @gemeente-denhaag/list@0.1.7 - @gemeente-denhaag/menuitem@0.1.7 - @gemeente-denhaag/menulist@0.1.7 - @gemeente-denhaag/menu@0.1.7 - @gemeente-denhaag/mobilestepper@0.1.7 - @gemeente-denhaag/paper@0.1.7 - @gemeente-denhaag/pickersutilsprovider@0.1.10 - @gemeente-denhaag/pickers@0.1.14 - @gemeente-denhaag/popover@0.1.7 - @gemeente-denhaag/popper@0.1.7 - @gemeente-denhaag/radiogroup@0.1.7 - @gemeente-denhaag/radio@0.1.7 - @gemeente-denhaag/select@0.1.7 - @gemeente-denhaag/stepbutton@0.1.7 - @gemeente-denhaag/stepconnector@0.1.7 - @gemeente-denhaag/stepcontent@0.1.7 - @gemeente-denhaag/stepicon@0.1.7 - @gemeente-denhaag/steplabel@0.1.7 - @gemeente-denhaag/step@0.1.7 - @gemeente-denhaag/stepper@0.1.7 - @gemeente-denhaag/swipeabledrawer@0.1.7 - @gemeente-denhaag/switch@0.1.7 - @gemeente-denhaag/tabcontext@0.1.7 - @gemeente-denhaag/tablist@0.1.7 - @gemeente-denhaag/tabpanel@0.1.7 - @gemeente-denhaag/tabscrollbutton@0.1.7 - @gemeente-denhaag/tab@0.1.7 - @gemeente-denhaag/tabs@0.1.7 - @gemeente-denhaag/textfield@0.1.7 - @gemeente-denhaag/toolbar@0.1.7 - @gemeente-denhaag/typography@0.1.7 - @gemeente-denhaag/datadisplay@0.1.5 - @gemeente-denhaag/denhaag-component-library@0.1.14 - @gemeente-denhaag/input@0.1.12 - @gemeente-denhaag/layout@0.1.5 - @gemeente-denhaag/navigation@0.1.5 - @gemeente-denhaag/surfaces@0.1.5

Sprint 7 merge 2

- @gemeente-denhaag/accordion@0.1.7 - @gemeente-denhaag/accordionactions@0.1.7 - @gemeente-denhaag/accordiondetails@0.1.7 - @gemeente-denhaag/accordionsummary@0.1.7 - @gemeente-denhaag/appbar@0.1.7 - @gemeente-denhaag/avatar@0.1.7 - @gemeente-denhaag/avatargroup@0.1.7 - @gemeente-denhaag/badge@0.1.7 - @gemeente-denhaag/basedatadisplayprops@0.1.7 - @gemeente-denhaag/baselayoutprops@0.1.7 - @gemeente-denhaag/baseprops@0.1.7 - @gemeente-denhaag/box@0.1.7 - @gemeente-denhaag/button@0.1.7 - @gemeente-denhaag/buttongroup@0.1.7 - @gemeente-denhaag/card@0.1.7 - @gemeente-denhaag/cardactions@0.1.7 - @gemeente-denhaag/cardcontent@0.1.7 - @gemeente-denhaag/cardheader@0.1.7 - @gemeente-denhaag/checkbox@0.1.7 - @gemeente-denhaag/container@0.1.7 - @gemeente-denhaag/divider@0.1.7 - @gemeente-denhaag/drawer@0.1.7 - @gemeente-denhaag/formcontrol@0.1.7 - @gemeente-denhaag/formcontrollabel@0.1.7 - @gemeente-denhaag/formgroup@0.1.7 - @gemeente-denhaag/grid@0.1.7 - @gemeente-denhaag/gridlist@0.1.7 - @gemeente-denhaag/gridlisttile@0.1.7 - @gemeente-denhaag/gridlisttilebar@0.1.7 - @gemeente-denhaag/hidden@0.1.7 - @gemeente-denhaag/iconbutton@0.1.7 - @gemeente-denhaag/inputlabel@0.1.7 - @gemeente-denhaag/link@0.0.2 - @gemeente-denhaag/list@0.1.7 - @gemeente-denhaag/listitem@0.1.7 - @gemeente-denhaag/listitemavatar@0.1.7 - @gemeente-denhaag/listitemicon@0.1.7 - @gemeente-denhaag/listitemsecondaryaction@0.1.7 - @gemeente-denhaag/listitemtext@0.1.7 - @gemeente-denhaag/listsubheader@0.1.7 - @gemeente-denhaag/menu@0.1.7 - @gemeente-denhaag/menuitem@0.1.7 - @gemeente-denhaag/menulist@0.1.7 - @gemeente-denhaag/mobilestepper@0.1.7 - @gemeente-denhaag/paper@0.1.7 - @gemeente-denhaag/pickers@0.1.14 - @gemeente-denhaag/pickersutilsprovider@0.1.10 - @gemeente-denhaag/popover@0.1.7 - @gemeente-denhaag/popper@0.1.7 - @gemeente-denhaag/radio@0.1.7 - @gemeente-denhaag/radiogroup@0.1.7 - @gemeente-denhaag/select@0.1.7 - @gemeente-denhaag/step@0.1.7 - @gemeente-denhaag/stepbutton@0.1.7 - @gemeente-denhaag/stepconnector@0.1.7 - @gemeente-denhaag/stepcontent@0.1.7 - @gemeente-denhaag/stepicon@0.1.7 - @gemeente-denhaag/steplabel@0.1.7 - @gemeente-denhaag/stepper@0.1.7 - @gemeente-denhaag/swipeabledrawer@0.1.7 - @gemeente-denhaag/switch@0.1.7 - @gemeente-denhaag/tab@0.1.7 - @gemeente-denhaag/tabcontext@0.1.7 - @gemeente-denhaag/tablist@0.1.7 - @gemeente-denhaag/tabpanel@0.1.7 - @gemeente-denhaag/tabscrollbutton@0.1.7 - @gemeente-denhaag/tabs@0.1.7 - @gemeente-denhaag/textfield@0.1.7 - @gemeente-denhaag/toolbar@0.1.7 - @gemeente-denhaag/typography@0.1.7 - @gemeente-denhaag/datadisplay@0.1.5 - @gemeente-denhaag/denhaag-component-library@0.1.14 - @gemeente-denhaag/input@0.1.12 - @gemeente-denhaag/layout@0.1.5 - @gemeente-denhaag/navigation@0.1.5 - @gemeente-denhaag/surfaces@0.1.5

…DenHaag/denhaag-component-library into fix/#42-fix-installation-files

…emeente-DenHaag/denhaag-component-library into fix/#42-fix-installation-files

package.json

bddjong · 2021-04-24T09:24:55Z

There's a lot of discoveries in how we can test these packages locally, and a lot of changes in how it builds. Is there anything we can document in the README.md or CONTRIBUTING.md?

src/components/TextField/src/TextField.stories.tsx

bddjong · 2021-04-24T11:11:24Z

Plz never make me do this again

joostvanviegen · 2021-04-24T14:44:48Z

.storybook/main.js

-    '../src/stories/*/*.stories.@(js|jsx|ts|tsx)',
+    './stories/*.stories.mdx',
+    '../src/components/*/*.stories.mdx',
+    '../src/components/*/src/*.stories.@(js|jsx|ts|tsx)'


Do we actually have files residing at a location identified by this regex?

3 and 5 are used. 4 is not, I will remove it

joostvanviegen · 2021-04-24T14:46:49Z

lerna.json

@@ -4,7 +4,7 @@
  "version": "independent",
  "command": {
      "publish": {
-        "allowBranch": "development"
+        "allowBranch": "master"


The reasoning behind allowing development was the inability to push to master, has this been changed?

no, I think this was a mistake

src/components/List/src/index.tsx

src/components/Pickers/src/index.tsx

src/components/StepLabel/src/index.tsx

joostvanviegen

I approve of these fixes, i do think however that we should remove the lines which have been commented out (instead of being removed) to keep things tidy.

mjcarsjens

I approve these changes, once Joost's comments have been resolved this can be merged imo

* add script to bulk update package.json files * Renamed and moved source files Renamed all files to index.tsx and moved into src directory. This is to be inline with conventions. * Update fields in package.json * fix bug in update script * sorted package.json files * fix build * Only allow lerna publish from master * add dependency to steplabel * updated package.json jsx flag * add production key to microbundle * added peerdependency on react, fixed imports * picker potential fix * pickers index cleanup * pickerutilsprovider fix * removed duplicate export of defaults * use tsc instead of microbundler * Merge branch 'fix/#42-fix-installation-files' of https://github.com/Gemeente-DenHaag/denhaag-component-library into fix/#42-fix-installation-files * fix dependencies and add npmignore * remove files field from package.json * Fixing imports in storybook stories * Moved stories to component directory Co-authored-by: Maarten <GewoonMaarten@users.noreply.github.com> * remove old paths * update files field in package.json * add build config to meta-packages * remove module field from tsconfig * update clean script * remove deprecated script * fixing compatibility of yarn clean for windows & linux * update tsconfig path and remove npmignore * update clean script * update steplabel command * upgraded dependencies of react and storybook, fixed stories * merge fix * update react and storybook * upgraded storybook dependencies * yarn lock update * fix textfield import * remove src from imports * add doc for install packages locally to contributing.md * remove trailing comma * make incremental build actually work * remove commented code Co-authored-by: Maarten Carsjens <mjcarsjens@gmail.com> Co-authored-by: bdjong <bryandejong99@gmail.com> Co-authored-by: Maarten Carsjens <maarten.carsjens@gxsoftware.com> Co-authored-by: DanielvanVliet <danielvvliet@hotmail.com>

* Only allow lerna publish from master * Publish - @gemeente-denhaag/accordionactions@0.1.7 - @gemeente-denhaag/accordiondetails@0.1.7 - @gemeente-denhaag/accordionsummary@0.1.7 - @gemeente-denhaag/accordion@0.1.7 - @gemeente-denhaag/appbar@0.1.7 - @gemeente-denhaag/avatargroup@0.1.7 - @gemeente-denhaag/avatar@0.1.7 - @gemeente-denhaag/badge@0.1.7 - @gemeente-denhaag/basedatadisplayprops@0.1.7 - @gemeente-denhaag/baselayoutprops@0.1.7 - @gemeente-denhaag/baseprops@0.1.7 - @gemeente-denhaag/box@0.1.7 - @gemeente-denhaag/buttongroup@0.1.7 - @gemeente-denhaag/button@0.1.7 - @gemeente-denhaag/cardactions@0.1.7 - @gemeente-denhaag/cardcontent@0.1.7 - @gemeente-denhaag/cardheader@0.1.7 - @gemeente-denhaag/card@0.1.7 - @gemeente-denhaag/checkbox@0.1.7 - @gemeente-denhaag/container@0.1.7 - @gemeente-denhaag/divider@0.1.7 - @gemeente-denhaag/drawer@0.1.7 - @gemeente-denhaag/formcontrollabel@0.1.7 - @gemeente-denhaag/formcontrol@0.1.7 - @gemeente-denhaag/formgroup@0.1.7 - @gemeente-denhaag/gridlisttilebar@0.1.7 - @gemeente-denhaag/gridlisttile@0.1.7 - @gemeente-denhaag/gridlist@0.1.7 - @gemeente-denhaag/grid@0.1.7 - @gemeente-denhaag/hidden@0.1.7 - @gemeente-denhaag/iconbutton@0.1.7 - @gemeente-denhaag/inputlabel@0.1.7 - @gemeente-denhaag/link@0.0.2 - @gemeente-denhaag/listitemavatar@0.1.7 - @gemeente-denhaag/listitemicon@0.1.7 - @gemeente-denhaag/listitemsecondaryaction@0.1.7 - @gemeente-denhaag/listitemtext@0.1.7 - @gemeente-denhaag/listitem@0.1.7 - @gemeente-denhaag/listsubheader@0.1.7 - @gemeente-denhaag/list@0.1.7 - @gemeente-denhaag/menuitem@0.1.7 - @gemeente-denhaag/menulist@0.1.7 - @gemeente-denhaag/menu@0.1.7 - @gemeente-denhaag/mobilestepper@0.1.7 - @gemeente-denhaag/paper@0.1.7 - @gemeente-denhaag/pickersutilsprovider@0.1.10 - @gemeente-denhaag/pickers@0.1.14 - @gemeente-denhaag/popover@0.1.7 - @gemeente-denhaag/popper@0.1.7 - @gemeente-denhaag/radiogroup@0.1.7 - @gemeente-denhaag/radio@0.1.7 - @gemeente-denhaag/select@0.1.7 - @gemeente-denhaag/stepbutton@0.1.7 - @gemeente-denhaag/stepconnector@0.1.7 - @gemeente-denhaag/stepcontent@0.1.7 - @gemeente-denhaag/stepicon@0.1.7 - @gemeente-denhaag/steplabel@0.1.7 - @gemeente-denhaag/step@0.1.7 - @gemeente-denhaag/stepper@0.1.7 - @gemeente-denhaag/swipeabledrawer@0.1.7 - @gemeente-denhaag/switch@0.1.7 - @gemeente-denhaag/tabcontext@0.1.7 - @gemeente-denhaag/tablist@0.1.7 - @gemeente-denhaag/tabpanel@0.1.7 - @gemeente-denhaag/tabscrollbutton@0.1.7 - @gemeente-denhaag/tab@0.1.7 - @gemeente-denhaag/tabs@0.1.7 - @gemeente-denhaag/textfield@0.1.7 - @gemeente-denhaag/toolbar@0.1.7 - @gemeente-denhaag/typography@0.1.7 - @gemeente-denhaag/datadisplay@0.1.5 - @gemeente-denhaag/denhaag-component-library@0.1.14 - @gemeente-denhaag/input@0.1.12 - @gemeente-denhaag/layout@0.1.5 - @gemeente-denhaag/navigation@0.1.5 - @gemeente-denhaag/surfaces@0.1.5 * Added initial version of card and cardheader styling * Applied styling to Card and changed card's hex values to hsl * switching cardstyle based on the variant. * Added color to card case and padding to the top of card * WIP:Including multiple components in Card Including multiple components in card to adhere to the designs. * Removed padding from cardcontent * Moved cards story to reflect the way cards are represented in the designs * Fixed arrow position and text color * Fixed border of Case / card Added font weight to title and subtitle Sorted css file by property / design token names * Added paper svg file to case / card * Added title, subtitle and date properties to card * Correctly padded date on left side * Correctly positioned the date and arrow on cards Co-authored-by: Daniel van Vliet <Danielvvliet@hotmail.com> * Suggested changes to Card to show properly as folder and changed around class names to be conform BEM standards * Added correct borders to card/case Co-authored-by: Daniel van Vliet <Danielvvliet@hotmail.com> * Added on-hover perspective change to card/case * Remove merge conflicts and reduce amount of design tokens for Button * Made text darker on hover * WIP: focus border color title and subtitle * Add base styles package * Add css as default export * Change tsx in basestyles/package.json to ts * Changed colour hex values to hsl (Hue Saturation Luminesence) * Fix incorrect HSL value for --denhaag-green-1 * Changed hsl values to modern notation also reverted change in stylelint config to change color notation to modern. * Update README.md * Storybook show code fix (#117) * Show code showing actual code in layout Storybook. * Show code showing actual code in navigation Storybook. * Show code showing actual code in surfaces Storybook. * Show code showing actual code in data display Storybook. * Show code showing actual code in input Storybook. * Experimental commit, providing different types of code docs per component to properly display its implementation. * Redefined code examples of components based on best possible overview * Experimental commit: Show possibility of providing custom code documentation for each component variant in Storybook * Experimental commit: custom code docs per component. * Applied per-component docs specification for input components. * Applied per-component code doc specs to layout components. * Applied per-component code doc specs to navigation components. * Applied per-component code doc specs to surface components. * Shortened import * Defined custom code in separate variable to fix indentation * Defined custom code in separate variable to fix indentation for input components. * Defined custom code in separate variable to fix indentation for navigation components. * Defined custom code in separate variable to fix indentation for navigation (yes, twice) components. * Defined custom code in separate variable to fix indentation for surface components. * Fixed indendation for surfaces.. Again... * Fixed indendation for navigation.. Again... * Fixed indendation for layout.. Again... * Fixed indendation for input.. Again... * Fixed indendation for datadisplay.. Again... * Prettifier go brrr * Prettifier go brrr and also fixed indentation again because Checkboxes decided to be selfish pricks. Co-authored-by: Maarten Carsjens <maarten.carsjens@gxsoftware.com> * Fix/#42 fix installation files (#137) * add script to bulk update package.json files * Renamed and moved source files Renamed all files to index.tsx and moved into src directory. This is to be inline with conventions. * Update fields in package.json * fix bug in update script * sorted package.json files * fix build * Only allow lerna publish from master * add dependency to steplabel * updated package.json jsx flag * add production key to microbundle * added peerdependency on react, fixed imports * picker potential fix * pickers index cleanup * pickerutilsprovider fix * removed duplicate export of defaults * use tsc instead of microbundler * Merge branch 'fix/#42-fix-installation-files' of https://github.com/Gemeente-DenHaag/denhaag-component-library into fix/#42-fix-installation-files * fix dependencies and add npmignore * remove files field from package.json * Fixing imports in storybook stories * Moved stories to component directory Co-authored-by: Maarten <GewoonMaarten@users.noreply.github.com> * remove old paths * update files field in package.json * add build config to meta-packages * remove module field from tsconfig * update clean script * remove deprecated script * fixing compatibility of yarn clean for windows & linux * update tsconfig path and remove npmignore * update clean script * update steplabel command * upgraded dependencies of react and storybook, fixed stories * merge fix * update react and storybook * upgraded storybook dependencies * yarn lock update * fix textfield import * remove src from imports * add doc for install packages locally to contributing.md * remove trailing comma * make incremental build actually work * remove commented code Co-authored-by: Maarten Carsjens <mjcarsjens@gmail.com> Co-authored-by: bdjong <bryandejong99@gmail.com> Co-authored-by: Maarten Carsjens <maarten.carsjens@gxsoftware.com> Co-authored-by: DanielvanVliet <danielvvliet@hotmail.com> * Hot fix (#149) * fix incorrect git merge in IconButton * add compiler options for root tsconfig.json Appearantly this tsconfig.json is used by storybook. It doesn't show the controls if the compiler options are not included * update paths for linters * make husky scripts executable * Eslint storybook warning fixes * More eslint warnings in storybook files fixed Co-authored-by: DanielvanVliet <danielvvliet@hotmail.com> * Feature/#46 icons (#158) * add boilerplate project * add the ability for storybook to include svg files * wrap svgIcon * move svg icon file * add default story * add type support for svg files * add all svg icons from figma * update svg type * wrap all icons * forward props * display all icons in storybook * replace all fill and stroke values with "currentColor" * fix icon fill * update shapeRendering to be enum * add single icon story * install svgo and add to build script optimize all the svgs! * Update README with contributing info * update show code for single icon * replace material icons with our own in storybook stories * replace x with * * remove @material-ui/icons as dependency * Move basestyles to styles subfolder * Split design tokens and brand tokens * Add styles folder to workspaces * Use den haag brand tokens in storybook * Fixed visibility of focus border * Made card focussable * merge changes * Removed include of card story in tsconfig cardactions * Add css files to dist directories of Card, CardHeader, CardContent * Fixed style of card/case on focus * Fixed story book args to map to interface * Removed unused raised property from card * Moved card /case design tokens into Basestyles Package * Use builtin fontsizes * Fixed some design token references in Card/Case * Increased height on background::before to remove gap * Compensate padding of border text with focus * Added workaround because of chrome focus state * Changed font size token to point to correct css variable * Updated the Card because of new styling packages * Move css to .css files instead of .module.css to fix clean react project issues * change css variable names to adhere correct naming scheme * Changed naming of some css variables * Changed focusborder of text to outline and added outline to arrow of Card/Case * Added onclick and tabindex as properties * NewLines * Fix spelling errors secundary -> secondary * Remove commented code * Simplified border radiu of card--case * Remove obsolete tokens files * Use React event for onclick * Fixed bem classnames * Added time html5 tag around the date in card * Fixed the input of time html5 tag * Renamed CardActions file and reduced exports of Card * Fix MouseEvent type * Move some remaiing tokens to tokens-card * Sorted all properties alphabetically * card-header bem naming * Remove cardcasefocusclasses from bem mapping * Rename card__text wrapper to card-text-wrapper * Move cardactions styling token to tokens-card * Cleanup properties of actions and content * Removed obsolete cardheader component * added --hover and --focus to selectors and formatted the selectors better * Correctly fix bem naming of the text wrapper * Fixed some inconsistencies in card.css * Added stylelint ignore line descending specifity In order to ignore descending specifity for one line which would otherwise result in duplicated css just for testing purposes. * Clearer naming of wrapper padding * Change override of cardcontent: use start and end * Added focus border around all arrow card variants * split title padding tokens * removed tabindex from card/case and changed the title to an anchor tag. Fixed focus styles to work with these changes. * replaced padding inline and block properties by their start and end counterparts Co-authored-by: Daniel van Vliet <Danielvvliet@hotmail.com> * Ran prettier to fix some minor issues * Fixed CSS token naming * removed typography component Co-authored-by: Maarten Carsjens <mjcarsjens@gmail.com> Co-authored-by: Maarten <GewoonMaarten@users.noreply.github.com> Co-authored-by: bdjong <bryandejong99@gmail.com> Co-authored-by: Maarten Carsjens <maarten.carsjens@gxsoftware.com> Co-authored-by: Daniel van Vliet <Danielvvliet@hotmail.com> Co-authored-by: Bryan de Jong <bryan.dejong@denhaag.nl> Co-authored-by: Jeroen de Klerk <jtech.work@protonmail.com>

mjcarsjens and others added 30 commits January 7, 2021 14:01

Merge pull request #1 from Gemeente-DenHaag/development

c1fe19b

GH config changes and updated project README.md

Merge pull request #18 from Gemeente-DenHaag/development

c113a56

Sprint 5

Merge pull request #47 from Gemeente-DenHaag/development

5cf2a80

Sprint 6 merge 1

add script to bulk update package.json files

c0a2218

Renamed and moved source files

465b9d9

Renamed all files to index.tsx and moved into src directory. This is to be inline with conventions.

Update fields in package.json

3b55ed5

fix bug in update script

76ed007

sorted package.json files

ac1f401

fix build

0454db1

Merge pull request #97 from Gemeente-DenHaag/development

48056ab

Sprint 7 merge 1

Only allow lerna publish from master

61b3fc9

Merge pull request #108 from Gemeente-DenHaag/development

b1ca3b8

Sprint 7 merge 2

Merge commit from 'fix/bundler' into fix/#42-fix-installation-files

896e9ca

add dependency to steplabel

bba8af0

updated package.json jsx flag

8a90e93

add production key to microbundle

d6ea954

added peerdependency on react, fixed imports

e1c929e

Merge branch 'master' into fix/installation-files

071f0e3

picker potential fix

1f5c959

pickers index cleanup

ca43e75

pickerutilsprovider fix

a641a82

Merge branch 'fix/#42-fix-installation-files' of github.com:Gemeente-…

f7b5312

…DenHaag/denhaag-component-library into fix/#42-fix-installation-files

removed duplicate export of defaults

858120e

use tsc instead of microbundler

05429d4

Merge branch 'fix/#42-fix-installation-files' of https://github.com/G…

516fdae

…emeente-DenHaag/denhaag-component-library into fix/#42-fix-installation-files

Merge branch 'fix/#42-fix-installation-files' of https://github.com/G…

30e9765

…emeente-DenHaag/denhaag-component-library into fix/#42-fix-installation-files

fix dependencies and add npmignore

97dc6f8

Merge branch 'fix/#42-fix-installation-files' of https://github.com/G…

c2e9658

…emeente-DenHaag/denhaag-component-library into fix/#42-fix-installation-files

DanielvanVliet requested a review from mjcarsjens April 21, 2021 14:33

bddjong reviewed Apr 24, 2021

View reviewed changes

package.json Show resolved Hide resolved

DanielvanVliet reviewed Apr 24, 2021

View reviewed changes

src/components/TextField/src/TextField.stories.tsx Outdated Show resolved Hide resolved

GewoonMaarten added 2 commits April 24, 2021 11:58

fix textfield import

3bb2b1e

remove src from imports

4e025f5

bddjong self-requested a review April 24, 2021 11:36

bddjong approved these changes Apr 24, 2021

View reviewed changes

GewoonMaarten added 2 commits April 24, 2021 14:24

Merge branch 'development' into fix/#42-fix-installation-files

a5698e8

add doc for install packages locally to contributing.md

e34a13f

joostvanviegen reviewed Apr 24, 2021

View reviewed changes

ogjtech approved these changes Apr 24, 2021

View reviewed changes

joostvanviegen reviewed Apr 24, 2021

View reviewed changes

src/components/List/src/index.tsx Outdated Show resolved Hide resolved

joostvanviegen reviewed Apr 24, 2021

View reviewed changes

src/components/Pickers/src/index.tsx Outdated Show resolved Hide resolved

joostvanviegen reviewed Apr 24, 2021

View reviewed changes

src/components/StepLabel/src/index.tsx Outdated Show resolved Hide resolved

joostvanviegen approved these changes Apr 24, 2021

View reviewed changes

GewoonMaarten added 2 commits April 25, 2021 00:54

remove trailing comma

98813e6

make incremental build actually work

9db2352

mjcarsjens approved these changes Apr 28, 2021

View reviewed changes

remove commented code

08ac068

GewoonMaarten merged commit 181ab64 into development Apr 28, 2021

GewoonMaarten deleted the fix/#42-fix-installation-files branch April 28, 2021 07:51

GewoonMaarten mentioned this pull request Apr 28, 2021

Sprint 8 Merge #147

Closed

GewoonMaarten restored the fix/#42-fix-installation-files branch April 28, 2021 10:12

GewoonMaarten deleted the fix/#42-fix-installation-files branch May 5, 2021 11:59

DanielvanVliet mentioned this pull request May 8, 2021

Release - 0.1.15 #166

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix/#42 fix installation files #137

Fix/#42 fix installation files #137

GewoonMaarten commented Apr 17, 2021 •

edited

bddjong commented Apr 24, 2021

bddjong commented Apr 24, 2021

joostvanviegen Apr 24, 2021

GewoonMaarten Apr 28, 2021

joostvanviegen Apr 24, 2021

GewoonMaarten Apr 28, 2021

joostvanviegen left a comment

mjcarsjens left a comment

Fix/#42 fix installation files #137

Fix/#42 fix installation files #137

Conversation

GewoonMaarten commented Apr 17, 2021 • edited

bddjong commented Apr 24, 2021

bddjong commented Apr 24, 2021

joostvanviegen Apr 24, 2021

Choose a reason for hiding this comment

GewoonMaarten Apr 28, 2021

Choose a reason for hiding this comment

joostvanviegen Apr 24, 2021

Choose a reason for hiding this comment

GewoonMaarten Apr 28, 2021

Choose a reason for hiding this comment

joostvanviegen left a comment

Choose a reason for hiding this comment

mjcarsjens left a comment

Choose a reason for hiding this comment

GewoonMaarten commented Apr 17, 2021 •

edited