Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storybook): setup chromatic #70

Merged
merged 8 commits into from
May 15, 2024
Merged

Conversation

remypar5
Copy link
Contributor

@remypar5 remypar5 commented May 3, 2024

Dingen om op te letten:

  • de pipeline faalt. Dit is eerste opzet, dus die moet nog gefixt worden
  • ik heb een achtergrond toegevoegd voor alle stories. Voor de visual regression stories gebruik ik een vast patroon als achtergrond. Dit laat duidelijker zien waar de randen en achtergronden (boundaries) van het component zich bevinden
  • de visual regression story heet "Visual". Deze wil ik proberen uit het zijmenu te halen omdat het voor onze eindgebruikers niet van belangrijk is om te zien.
  • momenteel staan zowel light als dark mode in een enkele story. Dat gaan we later oplossen door een keuze te bieden.

@remypar5 remypar5 requested a review from rwittenberns May 3, 2024 17:46
Copy link

vercel bot commented May 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lux ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 3:18pm

@remypar5 remypar5 requested a review from MrSkippy May 3, 2024 17:46
@remypar5 remypar5 requested a review from matijs May 3, 2024 18:02
Copy link
Member

@matijs matijs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments achtergelaten

.github/workflows/continuous-deployment.yml Outdated Show resolved Hide resolved
packages/storybook/config/main.ts Outdated Show resolved Hide resolved
packages/storybook/config/preview.tsx Show resolved Hide resolved
packages/storybook/package.json Outdated Show resolved Hide resolved
@Robbert
Copy link
Member

Robbert commented May 14, 2024

Denk dat je zoiets nodig hebt:

    steps:
      - name: Download code from GitHub
        uses: actions/checkout@v4.1.2
        with:
          fetch-depth: 0

      - name: Install pnpm package manager
        uses: pnpm/action-setup@v3.0.0
        with:
          version: 8.14.1

      - name: Set up Node.js version
        uses: actions/setup-node@v4.0.2
        with:
          node-version-file: .nvmrc
          cache: pnpm

      - name: Install dependencies specified in package.json
        run: |
          pnpm install
          pnpm ls --recursive

       - name: "Restore build artifact: Storybook"
         uses: actions/download-artifact@v4.1.4
         with:
           name: storybook
           path: packages/storybook/dist/

       - name: Publish to Chromatic
         uses: chromaui/action@v11
         if: |
           github.event.pull_request.draft == false &&
           github.actor != 'dependabot[bot]'
         with:
           autoAcceptChanges: main
           projectToken: ${{ secrets.CHROMATIC_PROJECT_TOKEN }}
           storybookBuildDir: packages/storybook/dist/

@remypar5 remypar5 requested a review from matijs May 15, 2024 07:47
@remypar5 remypar5 merged commit 48d06e7 into main May 15, 2024
10 checks passed
@remypar5 remypar5 deleted the feat/LUX-38-implement-chromatic branch May 15, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants