This repository has been archived by the owner on Feb 21, 2020. It is now read-only.
re-initialise chrome if disconnected #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ato
suggested changes
Jan 23, 2017
| String contextId; | ||
|
|
||
| private void init() throws IOException, TimeoutException, InterruptedException { | ||
| chrome = this.chrome = new Chropro("ws://" + this.chromeHost + ":" + this.chromePort + "/devtools/browser"); |
There was a problem hiding this comment.
I think chrome and this.chrome are the same field?
| targetId = chrome.target.createTarget("about:blank", w, h, contextId).get(timeout, MILLISECONDS).targetId; | ||
| } catch (WebsocketNotConnectedException ex) { | ||
| System.out.println("Lost connection to web service. Re-initialising chrome client."); | ||
| init(); |
There was a problem hiding this comment.
I think there's race here if two requests come in while the connection is dead and both try to re-establish it. The first across the line will have their connection replaced and leak. Maybe we could mark init() as 'synchronized' and also call close on the connection that we're replacing?
That can still race but at least it'll just cause a temporary error rather than a connection leak.
* cleanup initialisation of chrome in init() * mark init() as synchronised * close connection before replacing it
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ato Probably not the greatest way to do this, but at least the webapp will automatically reconnect to the webservice if it loses its connection (i.e. the headless-chromium service gets restarted).