-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to hide compilation buffer if all tests pass #49
Add option to hide compilation buffer if all tests pass #49
Conversation
phpunit.el
Outdated
(or (s-contains? "Time" x))) | ||
buffer-lines)))) | ||
(delete-windows-on buffer) | ||
(message "%s" (concat ok-msg " " time-msg)))))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
message
is similar to C's printf
.
(message "%s %s" ok-msg time-msg)
Maybe, follows test will be success always. <?php
final class OKTest extends \PHPUnit_Framework_TestCase
{
public function test()
{
$this->assertSame(1, 2, "OK");
}
}
|
Yes good point, I will try to make the check a bit more intelligent, thanks! |
phpunit.el
Outdated
(let* ((buffer-string (buffer-substring-no-properties | ||
(point-min) (point-max))) | ||
(buffer-lines (s-lines buffer-string))) | ||
(when-let ((ok-msg (car (cl-remove-if-not |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if-let
and when-let
are added in Emacs 25. Perhaps we should continue to support Emacs 24.3 for a while.
@mallt |
@zonuexe Thanks a lot for the comments, and sorry for the delay! I hope to update this PR soon. |
4e2c244
to
9b68ba2
Compare
Sorry for delay. |
Thanks! |
@mallt Sorry to miss it, thank you! |
This PR adds an option that will hide the compilation buffer if all tests pass and show the test result summary and time passed in the echo area:
Thanks!