Match valid classname in php-get-current-class
#7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`php-get-current-class` had been dropping any ".php" suffix from the file/buffer name and assuming that the remainder was the name of the class. This was not the best method of seeking the class name. As the syntax of valid PHP class names is known[1], a more flexible method was to seek such a class name in the filename. `php-get-current-class` now returns the first matching regexp in the filename as the name of the class. [1] http://www.php.net/manual/en/language.variables.basics.php
Best-guess approximation of how the function would be typeset if you had written it.
nlamirault
added a commit
that referenced
this pull request
Aug 21, 2015
Match valid classname in `php-get-current-class`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
php-get-current-classcurrently matches the name of a class by dropping any*.phpsuffix from the specified file or the current buffer name. This only works if the full suffix of the file is limited to*.php, unnecessarily enforcing an unstated convention.A better method of determining the name of the current class would be to seek a valid PHP class name in the filename. This would obviate any consideration of suffixing practices.