Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker image #227

Closed
moookino opened this issue Dec 8, 2022 · 5 comments · Fixed by #228
Closed

Docker image #227

moookino opened this issue Dec 8, 2022 · 5 comments · Fixed by #228
Assignees
Labels
Accepted suggestion A good suggestion for future versions Feature Request New feature or request Next release Extra attention is needed

Comments

@moookino
Copy link

moookino commented Dec 8, 2022

What would you like to see added?

Can you add docker image, which could be used as part of https://github.com/mkuf/prind stack?
I've created feature request to add telegram bot mkuf/prind#45

Thanks in advance

@moookino moookino added the Feature Request New feature or request label Dec 8, 2022
@nlef nlef linked a pull request Dec 10, 2022 that will close this issue
@nlef nlef added this to Long-Term suggestions in main development via automation Dec 11, 2022
@nlef nlef moved this from Long-Term suggestions to In Progress in main development Dec 11, 2022
@nlef nlef self-assigned this Dec 11, 2022
@nlef nlef added the Next release Extra attention is needed label Dec 11, 2022
@nlef nlef moved this from In Progress to testing in main development Dec 11, 2022
@nlef nlef moved this from testing to Working on dev in main development Dec 11, 2022
@mkuf
Copy link
Contributor

mkuf commented Dec 12, 2022

I just tried to add this Image to Prind in mkuf/prind#48

It seems, the Image is missing Dependencies.

Traceback (most recent call last):
  File "/opt/moonraker-telegram-bot/bot/main.py", line 41, in <module>
    from websocket_helper import WebSocketHelper
  File "/opt/moonraker-telegram-bot/bot/websocket_helper.py", line 11, in <module>
    from notifications import Notifier
  File "/opt/moonraker-telegram-bot/bot/notifications.py", line 11, in <module>
    from camera import Camera
  File "/opt/moonraker-telegram-bot/bot/camera.py", line 16, in <module>
    import cv2  # type: ignore
ModuleNotFoundError: No module named 'cv2'

This might be resolvable by adding the package to the requirements file instead of installing it via apt.

-Markus

nlef added a commit that referenced this issue Dec 12, 2022
@nlef
Copy link
Owner

nlef commented Dec 12, 2022

@mkuf I fixed Dockerfile. My mistake with system packages links in venv

@mkuf
Copy link
Contributor

mkuf commented Dec 13, 2022

Created a PR to add support for arm/v7 and arm64/v8: #231

@nlef
Copy link
Owner

nlef commented Jan 3, 2023

@mkuf @moookino
build pipeline is now fixed and docker images for arm are available at docker hub
Tag latest would be available with the next release.

@mkuf
Copy link
Contributor

mkuf commented Jan 3, 2023

Great 💯
The Service has been added to prind v1.4.0 yesterday. https://github.com/mkuf/prind/releases/tag/v1.4.0
Prind is currently using the development tag, it may move to latest in a future release as soon as the tag is available.

@aka13-404 aka13-404 added the Accepted suggestion A good suggestion for future versions label Feb 5, 2023
@aka13-404 aka13-404 moved this from Working on dev to Done/released in main development Feb 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted suggestion A good suggestion for future versions Feature Request New feature or request Next release Extra attention is needed
Projects
main development
Done/released
Development

Successfully merging a pull request may close this issue.

4 participants