Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Allow specification of a fixed ligand-vector dihedral angle #204

Merged
merged 5 commits into from
Nov 19, 2021

Conversation

BvB93
Copy link
Member

@BvB93 BvB93 commented Nov 19, 2021

Add the option to manually specify the dihedral angle addopted by the ligand vector, rather than optimizing it w.r.t. the inter-ligand distance.

The dihedral angle is herein defined by three vectors:

  • The first two indices in anchor.group_idx.
  • The core vector(s).
  • The Cartesian X-axis as defined by the core.

Examples

optional:
    ligand:
        anchor:
            group: OC(=O)C
            group_idx: [0, 1, 2]
            dihedral: 45

@BvB93 BvB93 added the enhancement New feature or request label Nov 19, 2021
@BvB93 BvB93 added this to the CAT 0.10.1 milestone Nov 19, 2021
@codecov
Copy link

codecov bot commented Nov 19, 2021

Codecov Report

Merging #204 (7c17563) into master (c586d13) will increase coverage by 0.24%.
The diff coverage is 85.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #204      +/-   ##
==========================================
+ Coverage   66.46%   66.70%   +0.24%     
==========================================
  Files          48       48              
  Lines        3868     3890      +22     
  Branches      674      678       +4     
==========================================
+ Hits         2571     2595      +24     
+ Misses       1129     1125       -4     
- Partials      168      170       +2     
Impacted Files Coverage Δ
CAT/data_handling/anchor_parsing.py 72.63% <45.45%> (+1.49%) ⬆️
CAT/attachment/ligand_attach.py 73.98% <100.00%> (+2.19%) ⬆️
CAT/utils.py 69.23% <100.00%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c586d13...7c17563. Read the comment docs.

@BvB93 BvB93 merged commit c5937c4 into master Nov 19, 2021
@BvB93 BvB93 deleted the dihedral branch November 19, 2021 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant