Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH,WIP: Add an option for inverting the core vectors #208

Merged
merged 1 commit into from
Dec 1, 2021
Merged

Conversation

BvB93
Copy link
Member

@BvB93 BvB93 commented Dec 1, 2021

This PR adds the surface_invert and sphere_invert options for optional.core.allignment,
which are used for inverting the core vectors.

Examples

core:
    optional:
        allignment: surface_invert

@BvB93 BvB93 added enhancement New feature or request Work in Progress Work in progress labels Dec 1, 2021
@BvB93 BvB93 added this to the CAT 0.10.1 milestone Dec 1, 2021
@codecov
Copy link

codecov bot commented Dec 1, 2021

Codecov Report

Merging #208 (fa26fe8) into master (988a910) will increase coverage by 0.16%.
The diff coverage is 89.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #208      +/-   ##
==========================================
+ Coverage   67.27%   67.43%   +0.16%     
==========================================
  Files          48       48              
  Lines        3890     3900      +10     
  Branches      697      699       +2     
==========================================
+ Hits         2617     2630      +13     
+ Misses       1116     1114       -2     
+ Partials      157      156       -1     
Impacted Files Coverage Δ
CAT/attachment/ligand_attach.py 75.08% <77.77%> (+1.09%) ⬆️
CAT/base.py 68.60% <100.00%> (+0.18%) ⬆️
CAT/data_handling/validation_schemas.py 92.07% <100.00%> (+0.16%) ⬆️
CAT/utils.py 70.04% <100.00%> (+0.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 988a910...fa26fe8. Read the comment docs.

@BvB93 BvB93 merged commit 23a3466 into master Dec 1, 2021
@BvB93 BvB93 deleted the allignment branch December 1, 2021 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Work in Progress Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant