Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Export warnings to the logger when running ARMC #271

Merged
merged 8 commits into from
Mar 9, 2022
Merged

Conversation

BvB93
Copy link
Member

@BvB93 BvB93 commented Mar 9, 2022

Also includes a couple of CI updates.

@BvB93 BvB93 added enhancement New feature or request Tests Updated the unit-tests labels Mar 9, 2022
@BvB93 BvB93 added this to the 0.10.2 milestone Mar 9, 2022
@BvB93 BvB93 self-assigned this Mar 9, 2022
@codecov
Copy link

codecov bot commented Mar 9, 2022

Codecov Report

Merging #271 (82faabc) into master (c9927ab) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 82faabc differs from pull request most recent head 851d886. Consider uploading reports for the commit 851d886 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #271      +/-   ##
==========================================
+ Coverage   75.24%   75.25%   +0.01%     
==========================================
  Files          66       66              
  Lines        7081     7092      +11     
  Branches     1358     1358              
==========================================
+ Hits         5328     5337       +9     
- Misses       1412     1414       +2     
  Partials      341      341              
Impacted Files Coverage Δ
FOX/armc/run_armc.py 76.92% <100.00%> (+5.04%) ⬆️
FOX/functions/charge_utils.py 85.07% <0.00%> (-1.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9927ab...851d886. Read the comment docs.

@BvB93 BvB93 merged commit ca3cd39 into master Mar 9, 2022
@BvB93 BvB93 deleted the logger2 branch March 9, 2022 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Tests Updated the unit-tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant