Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Do not abort fast-sigma computations if a crash is encountered for a single property #126

Merged
merged 2 commits into from
Jun 7, 2022

Conversation

BvB93
Copy link
Member

@BvB93 BvB93 commented Jun 7, 2022

@BvB93 BvB93 added the enhancement New feature or request label Jun 7, 2022
@BvB93 BvB93 closed this Jun 7, 2022
@BvB93 BvB93 reopened this Jun 7, 2022
@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

Merging #126 (0d7ceb6) into master (1f88974) will decrease coverage by 13.27%.
The diff coverage is 9.37%.

@@             Coverage Diff             @@
##           master     #126       +/-   ##
===========================================
- Coverage   61.62%   48.35%   -13.28%     
===========================================
  Files          36       36               
  Lines        2898     2881       -17     
===========================================
- Hits         1786     1393      -393     
- Misses       1112     1488      +376     
Impacted Files Coverage Δ
nanoCAT/recipes/fast_sigma.py 41.09% <9.37%> (+2.26%) ⬆️
nanoCAT/ff/cp2k_utils.py 13.79% <0.00%> (-86.21%) ⬇️
nanoCAT/asa/asa_frag.py 16.66% <0.00%> (-83.34%) ⬇️
nanoCAT/bde/bde_workflow.py 14.70% <0.00%> (-69.86%) ⬇️
nanoCAT/qd_opt_ff.py 20.58% <0.00%> (-69.61%) ⬇️
nanoCAT/bde/construct_xyn.py 16.49% <0.00%> (-63.92%) ⬇️
nanoCAT/ff/ff_assignment.py 31.11% <0.00%> (-51.12%) ⬇️
nanoCAT/ff/match_job.py 31.19% <0.00%> (-37.62%) ⬇️
nanoCAT/asa/md_asa.py 19.65% <0.00%> (-33.34%) ⬇️
nanoCAT/asa/asa.py 17.43% <0.00%> (-6.43%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f88974...0d7ceb6. Read the comment docs.

@BvB93 BvB93 merged commit 89951bd into master Jun 7, 2022
@BvB93 BvB93 deleted the crs2 branch June 7, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant