Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the library and the repo #8

Closed
fdiblen opened this issue Feb 17, 2022 · 8 comments
Closed

Rename the library and the repo #8

fdiblen opened this issue Feb 17, 2022 · 8 comments
Milestone

Comments

@fdiblen
Copy link
Member

fdiblen commented Feb 17, 2022

We should rename the library and use the same name for the repo for clarity.
Some suggestions:

  • cudacpp
  • cudacxx
  • cuda++
  • cudawrappers
  • your suggestion
@fdiblen fdiblen changed the title Rename the library Rename the library and the repo Feb 17, 2022
This was referenced Feb 17, 2022
@fdiblen fdiblen added this to the Taskpool milestone Feb 17, 2022
@jspaaks
Copy link
Contributor

jspaaks commented Feb 17, 2022

cudawrap

@fdiblen
Copy link
Member Author

fdiblen commented Feb 17, 2022

Our final suggestion is:
repo name: cuda-wrappers-for-cpp
library name: cuda-wrappers (libcuda-wrappers.so)

What do you think @benvanwerkhoven @isazi @bouweandela ?

@bouweandela
Copy link
Member

I think this would need to be discussed with our project partners @john-romein @csbnw and @svlugt

@fdiblen fdiblen added the needs-input Needs input from stakeholders label Feb 28, 2022
@john-romein
Copy link
Contributor

As the idea is very much inspired by the OpenCL C++ wrapper (which is, surprisingly, named ...: the OpenCL C++ wrapper), I think the name of this wrapper should be similar: the CUDA C++ wrapper.

@fdiblen fdiblen added standup and removed standup labels Mar 1, 2022
@john-romein
Copy link
Contributor

We prefer to keep cu:: as namespace.

@john-romein
Copy link
Contributor

There should be separate shared objects for the individual wrappers, to avoid that all CUDA libraries (libcuda.so, libcufft.so, libnvrtc.so etc.) need to be linked in as well, even if, for example, the user does not even use cufft).

@svlugt
Copy link

svlugt commented Mar 1, 2022

Load objects in cmake with find_package: e.g. use find_package(cudawrappers REQUIRED COMPONENTS nvrtc)

@fdiblen fdiblen added needs-grooming and removed needs-input Needs input from stakeholders labels Mar 2, 2022
@fdiblen
Copy link
Member Author

fdiblen commented Mar 2, 2022

As agreed this morning, we renamed the repository and the library as cudawarppers
Created #95 and #96 for the suggestions in the comments. Closing this issue.

@fdiblen fdiblen closed this as completed Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants