The users should know that no libraries will be built. #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good point Hanno, the documentation was clearly outdated. However, there will be only some CMake configuration files in the build directory, no headers. How about removing the build part from the documentation altogether, and just mention that it is header-only? |
csbnw
reviewed
Mar 6, 2024
This is indeed more accurate. Co-authored-by: Bram Veenboer <veenboer@astron.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The users should know that no libraries will be built, only headers will be produced.
The current README suggest that a
libcudawrappers-*.sowill appear in the build directory, which is not the case.Fixes #254