Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide more feedback to the committer #16

Merged
merged 1 commit into from
Mar 20, 2014

Conversation

elliotf
Copy link
Contributor

@elliotf elliotf commented Mar 20, 2014

While committing, the script pauses for however long your tests take to
run without any feedback. While this may be only a few seconds, it
would be nicer to know what is going on.

With this change it will first print out what it's doing, so the pause will show 'running X' while the committer is waiting:

running pre-commit checks...
running jshint:     ok
running validation: 

I also appealed to my OCD self and aligned the output so it's more scannable:

running pre-commit checks...
running jshint:     ok
running validation: ok
running tests:      ok

While committing, the script pauses for however long your tests take to
run without any feedback.  While this may be only a few seconds, it
would be nicer to know what is going on.
@nlf
Copy link
Owner

nlf commented Mar 20, 2014

nice, I like this. thanks for the patch

nlf added a commit that referenced this pull request Mar 20, 2014
@nlf nlf merged commit d316296 into nlf:master Mar 20, 2014
@elliotf
Copy link
Contributor Author

elliotf commented Mar 20, 2014

I'm glad you like it. Thank you for the time-saving module!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants