Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved items translation behavior, removal of translation mode option #30

Open
nliautaud opened this issue Oct 5, 2017 · 0 comments
Open

Improved items translation behavior, removal of translation mode option #30

nliautaud opened this issue Oct 5, 2017 · 0 comments
Labels
done / await testing enhancement
Milestone
v0.5

Comments

@nliautaud
Copy link
Owner

With the api caching (#28) allowing to distinguish between items who require an API call and those who don't, and by looking for items visible on viewport, the on load and on hover modes can be removed and replaced by a smartest behavior :

  • On page load, translate every cached items
  • On scroll and resize, translate every other items which are visible on the viewport
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
done / await testing enhancement
Projects
None yet
Milestone
v0.5
Development

No branches or pull requests
1 participant
@nliautaud