Import sycl::bit_cast into the Kokkos namespace

nliber · May 10, 2023 · 1bc1a51 · 1bc1a51
1 parent c62a42e
commit 1bc1a51
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/core/src/Kokkos_BitManipulation.hpp b/core/src/Kokkos_BitManipulation.hpp
@@ -100,6 +100,11 @@ inline constexpr bool is_standard_unsigned_integer_type_v =
 namespace Kokkos {
 
 //<editor-fold desc="[bit.cast], bit_cast">
+// FIXME_SYCL intel/llvm has unqualified calls to bit_cast which are ambiguous
+// if we declare our own bit_cast function
+#ifdef KOKKOS_ENABLE_SYCL
+using sycl::bit_cast;
+#else
 template <class To, class From>
 KOKKOS_FUNCTION std::enable_if_t<sizeof(To) == sizeof(From) &&
                                      std::is_trivially_copyable_v<To> &&
@@ -110,6 +115,7 @@ bit_cast(From const& from) noexcept {
   memcpy(&to, &from, sizeof(To));
   return to;
 }
+#endif
 //</editor-fold>
 
 //<editor-fold desc="[bit.byteswap], byteswap">

diff --git a/core/unit_test/TestBitManipulation.cpp b/core/unit_test/TestBitManipulation.cpp
@@ -500,6 +500,8 @@ constexpr X test_bit_cast(...) {
   return {};
 }
 
+// FIXME_SYCL The SYCL implementation is unconstrained
+#ifndef KOKKOS_ENABLE_SYCL
 namespace TypesNotTheSameSize {
 struct To {
   char a;
@@ -532,6 +534,7 @@ struct From {
 };
 static_assert(test_bit_cast<To, From>().did_not_match());
 }  // namespace FromNotTriviallyCopyable
+#endif
 
 namespace ReturnTypeIllFormed {
 struct From {