Only use absolute value of the difference #320
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mattfidler I have an alternate PR in the works that also has testing built in. Give me ~5 minutes. |
|
... the fix is functionally the same. |
|
Oops... |
|
Is the test the same too? |
|
The test is very similar. I just pushed it, so you can give it a look. My guess is that your test may be better. |
|
Its about the same. |
|
I don't have a preference for which gets merged. I'm just glad that I was able to make a reprex (and make a function modification to a C++ function!). |
|
Well since you were able to do so much, I prefer to merge yours 😄 |
mattfidler
deleted the
318-boundary-issue-triggered-when-lower-and-upper-bounds-are-on-both-sides-of-zero
branch
mattfidler
restored the
318-boundary-issue-triggered-when-lower-and-upper-bounds-are-on-both-sides-of-zero
branch
mattfidler
deleted the
318-boundary-issue-triggered-when-lower-and-upper-bounds-are-on-both-sides-of-zero
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.