Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add safeZero=FALSE default #147

Merged
merged 4 commits into from Jun 23, 2023
Merged

Conversation

mattfidler
Copy link
Contributor

No description provided.

@mattfidler mattfidler linked an issue Jun 23, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (2145774) 90.66% compared to head (8be668b) 90.66%.

❗ Current head 8be668b differs from pull request most recent head 1d54d11. Consider uploading reports for the commit 1d54d11 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #147   +/-   ##
=======================================
  Coverage   90.66%   90.66%           
=======================================
  Files          52       52           
  Lines        6339     6342    +3     
=======================================
+ Hits         5747     5750    +3     
  Misses        592      592           
Impacted Files Coverage Δ
R/rxSolve.R 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mattfidler mattfidler merged commit 3159fa4 into main Jun 23, 2023
7 checks passed
@mattfidler mattfidler deleted the 145-safezero-should-be-false-for-models branch June 23, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

safeZero should be FALSE for models
1 participant