Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: allow labels in model piping #351

Closed
billdenney opened this issue Nov 1, 2022 · 4 comments
Closed

Feature request: allow labels in model piping #351

billdenney opened this issue Nov 1, 2022 · 4 comments

Comments

@billdenney
Copy link
Contributor

When adding a new parameter with model piping, the parameter label will be empty. I think it would be helpful to also be able to add a label().

Is there already a way to do that?

@mattfidler
Copy link
Contributor

No, but I could see:

f %>% ini(parameter="label")

Or

f %>% ini(parameter="label")

@billdenney
Copy link
Contributor Author

As I'm working on some models where I'm making extensive use of piping, I had a new idea here. How about the following interface:

f %>% ini(parameter=label("new label"))

That way, it will be clearer for a user what is happening and simpler for us to find when a label is being changed. Thoughts?

@mattfidler
Copy link
Contributor

That could work too.

If we implement that approach, probably a error when trying ini(parameter="new label") telling that it should be ini(parameter=label("new label"))

@billdenney
Copy link
Contributor Author

This is fixed in #385.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants