Changes needed for future rstan

[andrjohns]

Hi,

This PR adds the changes to compiler and linker flags needed for the upcoming version of rstan/StanHeaders. All that was needed in this case was adding the RcppParallel include files and linker flags.

Let me know if you need any more info.

Thanks!
Andrew

[mattfidler]

Thanks @andrjohns

Running other checks. It is likely just fine

[mattfidler]

Somehow this fails.

[mattfidler]

I am re-running the base to see if it still works

[andrjohns]

Sorry about that, I updated the call to StanHeaders:::LdFlags() to satisfy Codefactor but it caused a different error. I've submitted the fix now

[andrjohns]

I've re-run these changes locally on Windows and I can't replicate the R CMD check error from the windows testing above, would you be able to test locally as well?

[andrjohns]

Apologies that this has been such a process. I was able to replicate the failure, it was caused by Windows linking against the wrong architecture for RcppParallel (i.e., was trying to link to 64-bit during 32-bit compilation)

[mattfidler]

Thia isnt needed anymore?

[andrjohns]

Apologies, thought I'd clicked close with comment. It's still needed, but I'll debug the errors on my fork rather than clogging up your PRs/actions

[mattfidler]

Ok. Thanks.