-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes needed for future rstan #460
Conversation
Thanks @andrjohns Running other checks. It is likely just fine |
Somehow this fails. |
I am re-running the base to see if it still works |
Sorry about that, I updated the call to |
I've re-run these changes locally on Windows and I can't replicate the R CMD check error from the windows testing above, would you be able to test locally as well? |
Apologies that this has been such a process. I was able to replicate the failure, it was caused by Windows linking against the wrong architecture for |
Thia isnt needed anymore? |
Apologies, thought I'd clicked close with comment. It's still needed, but I'll debug the errors on my fork rather than clogging up your PRs/actions |
Ok. Thanks. |
Hi,
This PR adds the changes to compiler and linker flags needed for the upcoming version of rstan/StanHeaders. All that was needed in this case was adding the RcppParallel include files and linker flags.
Let me know if you need any more info.
Thanks!
Andrew