test: add simplest test for ls
#111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trym-b
force-pushed
the
test/ls-test-data
branch
from
a16482e
to
529b51d
Compare
andrbo
approved these changes
Apr 2, 2024
# Motivation Many top level commands are missing tests. This is a first step to add a test for `ls` with proper test data. # Changes This commit adds a very simple test for `ls` that checks that it does not crash when reading a file. # Future work Add more checks to the test so that it is even better at avoiding regressions. # Acknowledgements Thanks to Ilya Kreymer for providing the test data through issue #99
trym-b
force-pushed
the
test/ls-test-data
branch
from
529b51d
to
82e3c44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Many top level commands are missing tests. This is a first step to add a test for
lswith propertest data.
Changes
This commit adds a very simple test for
lsthatchecks that it does not crash when reading a file.
Future work
Add more checks to the test so that it is even
better at avoiding regressions.
Acknowledgements
Thanks to Ilya Kreymer for providing the test data through issue
#99