Use the overloading mechanism instead of the optional parameters. #4911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Orace
force-pushed
the
remove_optional_parameters
branch
from
c6204ed
to
72bb844
Compare
|
SonarCloud Quality Gate failed. |
|
Must admit I like using default-parameters, so do not fully agree with Sonar (I like that one can see what default-value that will be used when not provided). But anyway I'm just the janitor. |
|
@Orace What problem does this solve? |
|
Closing pull-request is it has unresolved conflicts, and it also introduces breaking changes that must wait for NLog 6.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.