-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config: Implemented inheritance policy for autoReload in included config files #1116
Conversation
Current coverage is
|
/// Gets or sets a value indicating whether the configuration files | ||
/// should be watched for changes and reloaded automatically when changed. | ||
/// </summary> | ||
public bool AutoReload { get; set; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you tell me why this property is not needed anymore? it's now a breaking change!
Thanks! Which unit tests are new now? This is now a breaking change. We should try to get it non-breaking. |
All the other tests are new. |
…fig files. Added back AutoReload property to support clients who might use it.
…fig files. Make all method parameters required.
@304NotModified I have applied your feedback:
|
Thanks! IMO arrays are legacy stuff (and evil). Can you replace |
Done ;). |
NICE! |
Config: Implemented inheritance policy for autoReload in included config files
Fixes #668