Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove code dup of InternalLogger (T4) #1141

Merged
merged 3 commits into from
Jan 10, 2016
Merged

Conversation

304NotModified
Copy link
Member

T4 to generate code of InternalLogger

@codecov-io
Copy link

Current coverage is 73.36%

Merging #1141 into master will increase coverage by +0.01% as of 9e745df

@@            master   #1141   diff @@
======================================
  Files          264     265     +1
  Stmts        14945   14945       
  Branches      1638    1638       
  Methods          0       0       
======================================
+ Hit          10963   10964     +1
+ Partial        418     417     -1
  Missed        3564    3564       

Review entire Coverage Diff as of 9e745df


Uncovered Suggestions

  1. +0.08% via ...nternal/AspHelper.cs#206...218
  2. +0.08% via ...nternal/AspHelper.cs#188...200
  3. +0.08% via ...nternal/AspHelper.cs#170...182
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

@304NotModified 304NotModified added the enhancement Improvement on existing feature label Jan 8, 2016
@304NotModified 304NotModified added this to the 4.3 milestone Jan 8, 2016
@304NotModified 304NotModified changed the title Move code dup of InternalLogger to T4 Remove code dup of InternalLogger (T4) Jan 9, 2016
@bhaeussermann
Copy link
Contributor

I approve of this :).
But the branch is out-of-date, so I cannot merge :(

304NotModified added a commit that referenced this pull request Jan 10, 2016
Remove code dup of InternalLogger (T4)
@304NotModified 304NotModified merged commit a3dc26e into master Jan 10, 2016
@304NotModified
Copy link
Member Author

That's odd, I can merge without any change.

@304NotModified 304NotModified deleted the InternalLogger.tt branch January 15, 2016 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement on existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants