-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit test added for Variable node #1173
Unit test added for Variable node #1173
Conversation
This unit test is testing the thrown exception is NLogConfigurationException or not when variable node is written to wrong place.
Current coverage is
|
Thanks! Can you also make a variant where the |
+1 |
Sure. I made it using InlineData and Theory :) |
There are problems with Mono reference and Theory attribute (for Silverlight). I am going to remove Theory attribute but I am not sure about Mono error. It is not related to this commit. |
@UgurAldanmaz may be you just need to surround with conditional statements. |
Because of lack of Silverlight supporting.
Fixes #1128 |
…ts-for-wrong-variable-node-placement Unit test added for Variable node
Thanks! It had been merged! |
Thanks! I am closing related issue. |
This unit test is testing the thrown exception is
NLogConfigurationException or not when variable node is written to wrong
place.
For #1128
Configuration validation will be done at #1174