FileTarget: Don't throw an exception if a dir is missing when deleting old file on startup #1616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
close/reopen to rebuild on AppVeyor (who was stuck) |
Current coverage is 76% (diff: 0%)@@ master #1616 diff @@
==========================================
Files 270 270
Lines 16412 16416 +4
Methods 2621 2621
Messages 0 0
Branches 1788 1788
==========================================
- Hits 12521 12509 -12
- Misses 3488 3492 +4
- Partials 403 415 +12
|
|
codecov is buggy. There is an unit test added and it is working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even if throwException is on, this is not any helpful.
fixes #1605
This change is