Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archiving could append to extincting file #1680

Merged
merged 1 commit into from
Oct 8, 2016

Conversation

304NotModified
Copy link
Member

@304NotModified 304NotModified commented Oct 5, 2016

fixes #1645

Needed to solve issues if log writes are stuck in the nlog file and archived when starting

This change is Reviewable

@codecov-io
Copy link

codecov-io commented Oct 6, 2016

Current coverage is 81% (diff: 94%)

Merging #1680 into master will increase coverage by 1%

@@             master      #1680   diff @@
==========================================
  Files           274        274          
  Lines         16828      17792   +964   
  Methods        2664       2876   +212   
  Messages          0          0          
  Branches       1866       2106   +240   
==========================================
+ Hits          13475      14424   +949   
- Misses         2924       2930     +6   
- Partials        429        438     +9   

Sunburst

Powered by Codecov. Last update d2150d1...493c5c1

@304NotModified 304NotModified changed the title WIP: append to existing archive file Append to existing archive file Oct 8, 2016
@304NotModified 304NotModified merged commit a8a7739 into master Oct 8, 2016
@304NotModified 304NotModified deleted the archive-file-already-exists branch October 8, 2016 17:35
@304NotModified 304NotModified changed the title Append to existing archive file Archiving could append to extincting file Oct 11, 2016
@304NotModified 304NotModified added the file-archiving Issues with archiving with the file target label Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug report / Bug fix file-archiving Issues with archiving with the file target file-target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants