PropertiesLayoutRenderer - Check LogEventInfo.HasProperties first #1780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… avoid Properties-dictionary-allocation
Current coverage is 80% (diff: 89%)@@ master #1780 diff @@
==========================================
Files 277 277
Lines 17780 17789 +9
Methods 2785 2785
Messages 0 0
Branches 2024 2027 +3
==========================================
- Hits 14306 14305 -1
- Misses 3022 3031 +9
- Partials 452 453 +1
|
|
Good idea! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid allocating Properties-Dictionary, when just wanting to read from it.
This change is